diff for duplicates of <20111107112411.GC16470@localhost.localdomain> diff --git a/a/1.txt b/N1/1.txt index c1459b2..6bc7b94 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,30 +1,25 @@ On Fri, Nov 04, 2011 at 07:08:24PM -0500, Tabi Timur-B04825 wrote: -> On Fri, Nov 4, 2011 at 7:39 AM, Zhao Chenhui <chenhui.zhao@freescale.co= -m> wrote: ->=20 -> > + =A0 =A0 =A0 if (!pmc_regs) { -> > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 printk(KERN_WARNING "PMC is unavailable= -\n"); ->=20 +> On Fri, Nov 4, 2011 at 7:39 AM, Zhao Chenhui <chenhui.zhao@freescale.com> wrote: +> +> > + if (!pmc_regs) { +> > + printk(KERN_WARNING "PMC is unavailable\n"); +> > Use pr_warn() and the other pr_xxx functions. ->=20 -> > + =A0 =A0 =A0 pmcdr_mask =3D (u32 *)of_get_property(clk_np, "fsl,pmcd= -r-mask", NULL); ->=20 +> +> > + pmcdr_mask = (u32 *)of_get_property(clk_np, "fsl,pmcdr-mask", NULL); +> > The typecast is unnecessary here. ->=20 -> > + =A0 =A0 =A0 /* clear to enable clock in low power mode */ -> > + =A0 =A0 =A0 if (enable) -> > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 clrbits32(&pmc_regs->pmcdr, *pmcdr_mask= -); -> > + =A0 =A0 =A0 else -> > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 setbits32(&pmc_regs->pmcdr, *pmcdr_mask= -); ->=20 +> +> > + /* clear to enable clock in low power mode */ +> > + if (enable) +> > + clrbits32(&pmc_regs->pmcdr, *pmcdr_mask); +> > + else +> > + setbits32(&pmc_regs->pmcdr, *pmcdr_mask); +> > You need to use be32_to_cpup() when dereferencing a pointer to a > device tree property. ->=20 -> --=20 +> +> -- > Timur Tabi > Linux kernel developer at Freescale diff --git a/a/content_digest b/N1/content_digest index 371b2c5..a7aab89 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -4,39 +4,34 @@ "Subject\0Re: [PATCH 6/7] fsl_pmc: Add API to enable device as wakeup event source\0" "Date\0Mon, 7 Nov 2011 19:24:11 +0800\0" "To\0Tabi Timur-B04825 <B04825@freescale.com>\0" - "Cc\0netdev@vger.kernel.org <netdev@vger.kernel.org>" + "Cc\0Zhao Chenhui-B35336 <B35336@freescale.com>" linuxppc-dev@lists.ozlabs.org <linuxppc-dev@lists.ozlabs.org> Li Yang-R58472 <r58472@freescale.com> - " Zhao Chenhui-B35336 <B35336@freescale.com>\0" + " netdev@vger.kernel.org <netdev@vger.kernel.org>\0" "\00:1\0" "b\0" "On Fri, Nov 04, 2011 at 07:08:24PM -0500, Tabi Timur-B04825 wrote:\n" - "> On Fri, Nov 4, 2011 at 7:39 AM, Zhao Chenhui <chenhui.zhao@freescale.co=\n" - "m> wrote:\n" - ">=20\n" - "> > + =A0 =A0 =A0 if (!pmc_regs) {\n" - "> > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 printk(KERN_WARNING \"PMC is unavailable=\n" - "\\n\");\n" - ">=20\n" + "> On Fri, Nov 4, 2011 at 7:39 AM, Zhao Chenhui <chenhui.zhao@freescale.com> wrote:\n" + "> \n" + "> > + \302\240 \302\240 \302\240 if (!pmc_regs) {\n" + "> > + \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 printk(KERN_WARNING \"PMC is unavailable\\n\");\n" + "> \n" "> Use pr_warn() and the other pr_xxx functions.\n" - ">=20\n" - "> > + =A0 =A0 =A0 pmcdr_mask =3D (u32 *)of_get_property(clk_np, \"fsl,pmcd=\n" - "r-mask\", NULL);\n" - ">=20\n" + "> \n" + "> > + \302\240 \302\240 \302\240 pmcdr_mask = (u32 *)of_get_property(clk_np, \"fsl,pmcdr-mask\", NULL);\n" + "> \n" "> The typecast is unnecessary here.\n" - ">=20\n" - "> > + =A0 =A0 =A0 /* clear to enable clock in low power mode */\n" - "> > + =A0 =A0 =A0 if (enable)\n" - "> > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 clrbits32(&pmc_regs->pmcdr, *pmcdr_mask=\n" - ");\n" - "> > + =A0 =A0 =A0 else\n" - "> > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 setbits32(&pmc_regs->pmcdr, *pmcdr_mask=\n" - ");\n" - ">=20\n" + "> \n" + "> > + \302\240 \302\240 \302\240 /* clear to enable clock in low power mode */\n" + "> > + \302\240 \302\240 \302\240 if (enable)\n" + "> > + \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 clrbits32(&pmc_regs->pmcdr, *pmcdr_mask);\n" + "> > + \302\240 \302\240 \302\240 else\n" + "> > + \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 setbits32(&pmc_regs->pmcdr, *pmcdr_mask);\n" + "> \n" "> You need to use be32_to_cpup() when dereferencing a pointer to a\n" "> device tree property.\n" - ">=20\n" - "> --=20\n" + "> \n" + "> -- \n" "> Timur Tabi\n" "> Linux kernel developer at Freescale\n" "\n" @@ -44,4 +39,4 @@ "\n" -chenhui -32c67398e48267edd650b1941327a61e54be904f5531a95f165e951675da5c82 +9ba4948fc28bf4a2539958f889f2838b3918df47fe7ae2d13d6ff8ef3eb17e40
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.