Re: [Qemu-devel] [RFC] vmstate: Add copyrights for all cpus

["Edgar E. Iglesias" <edgar.iglesias@gmail.com>]

On Mon, Nov 07, 2011 at 06:38:49PM +0100, Juan Quintela wrote:
> Hi
> 
> This patch adds copyrights to all the machine description files for
> all architectures supported. (this is done on top of my vmstate-cpus
> series patches) The problem?
> 
> - What should we put as "copyirght" owners.
> 
> Althought I modified almost every line of the files, mostly of the
> changes are a conversion, so claiming myself as the only "copyright"
> owner sounds at least pretentious, and more than probably false.
> 
> I tried to "dig" into the git logs and tried to came with "whoever"
> commit the initial cpu_save/load foar each architecture.  I have put
> them as:
> 
>  * Based on qemu-file support done by:
>  *   Richard Henderson <rth@twiddle.net>
> 
> But I would preffer that the persons involved state what copyright
> notice they want, name, address, year(s), etc.  (Some architectures
> already have a propper copyright notice, I didn't touch them), and
> others had an empty file (I put mine there on the previosu series).
> 
> Several of the logs are from the svn days, and then I don't know if
> the person was the committer, or the author.  If anyone contributed
> to the functionality and want to add its copyright, please told me.
> 
> To make things more complicated, when machine.c files were split from
> vl.c, they didn't carry any copyright notice at all, should we copy
> back everything from vl.c?
> 
> To make things more complicated, it looks like Thiemo Seufer did the
> original mips support, and he passed away.  So he can't obviously
> comment.
> 
> Anthony asked me to send a patch to the list, asking form comments.
> 
> alpha:
> CC: Richard Henderson <rth@twiddle.net>
> 
> arm:
> CC: Andrzej Zaborowski <andrew.zaborowski@intel.com>
> 
>   (it appears as balrog, but on irc channel peter told me that balrog
>   has him)
> 
> cris:
> CC: Edgar E. Iglesias <edgar.iglesias@gmail.com>

...


>  static bool feature_vfp_needed(void *opaque)
> diff --git a/target-cris/vmstate-cpu.c b/target-cris/vmstate-cpu.c
> index 0f732d3..bbccb8b 100644
> --- a/target-cris/vmstate-cpu.c
> +++ b/target-cris/vmstate-cpu.c
> @@ -1,3 +1,18 @@
> +/*
> + * Migration support for cris cpus
> + *
> + * Copyright (C) 2011 Red Hat, Inc.
> + *
> + * Author(s):
> + *  Juan Quintela <quintela@redhat.com>
> + *
> + * Based on qemu-file support done by:
> + *  Edgar E. Iglesias <edgar.iglesias@gmail.com>
> + *
> + * This work is licensed under the terms of the GNU GPL, version 2.  See
> + * the COPYING file in the top-level directory.
> + */
> +
>  #include "hw/hw.h"
> 
>  static const VMStateDescription vmstate_tlbset = {


Hi Juan,

This is OK with me

Thanks,
Edgar