From: Ralf Baechle <ralf@linux-mips.org>
To: Michal Marek <mmarek@suse.cz>
Cc: Arnaud Lacombe <lacombar@gmail.com>,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mips@linux-mips.org,
David Daney <ddaney@caviumnetworks.com>
Subject: Re: [PATCH] Kbuild: append missing-syscalls to the default target list
Date: Mon, 7 Nov 2011 20:44:49 +0000 [thread overview]
Message-ID: <20111107204448.GA9949@linux-mips.org> (raw)
In-Reply-To: <20111101232233.GA32441@sepie.suse.cz>
On Wed, Nov 02, 2011 at 12:22:33AM +0100, Michal Marek wrote:
> On Wed, Sep 14, 2011 at 01:17:10AM -0400, Arnaud Lacombe wrote:
> > 2011/9/9 Michal Marek <mmarek@suse.cz>:
> > > On 25.8.2011 03:03, Arnaud Lacombe wrote:
> > >> +always += missing-syscalls
> > >> +targets += missing-syscalls
> > >> +
> > >> quiet_cmd_syscalls = CALL $<
> > >> cmd_syscalls = $(CONFIG_SHELL) $< $(CC) $(c_flags)
> > >
> > > checksyscalls.sh needs to depend on generated/asm-offsets.h, otherwise a
> > > parallel build will fail.
> > >
> > true.
> >
> > This:
> >
> > diff --git a/Kbuild b/Kbuild
> > index 1a2eb32..4caab4f 100644
> > --- a/Kbuild
> > +++ b/Kbuild
> > @@ -94,7 +94,7 @@ targets += missing-syscalls
> > quiet_cmd_syscalls = CALL $<
> > cmd_syscalls = $(CONFIG_SHELL) $< $(CC) $(c_flags)
> >
> > -missing-syscalls: scripts/checksyscalls.sh FORCE
> > +missing-syscalls: scripts/checksyscalls.sh $(offsets-file) FORCE
> > $(call cmd,syscalls)
>
> OK, applied to kbuild/kbuild with this fixup.
5f7efb4c6da9f90cb306923ced2a6494d065a595 breaks 64-bit MIPS builds that
have 32-bit binary compatibility enabled, for example ip27_defconfig
or cavium-octeon_defconfig:
CC arch/mips/kernel/asm-offsets.s
In file included from include/linux/bitops.h:22:0,
from include/linux/kernel.h:17,
from include/linux/cache.h:4,
from include/linux/time.h:7,
from include/linux/stat.h:60,
from include/linux/compat.h:10,
from arch/mips/kernel/asm-offsets.c:11:
/home/ralf/src/linux/linux-mips/arch/mips/include/asm/bitops.h: In function ‘__fls’:
/home/ralf/src/linux/linux-mips/arch/mips/include/asm/bitops.h:570:2: warning: left shift count >= width of type [enabled by default]
/home/ralf/src/linux/linux-mips/arch/mips/include/asm/bitops.h:572:3: warning: left shift count >= width of type [enabled by default]
/home/ralf/src/linux/linux-mips/arch/mips/include/asm/bitops.h:575:2: warning: left shift count >= width of type [enabled by default]
/home/ralf/src/linux/linux-mips/arch/mips/include/asm/bitops.h:579:2: warning: left shift count >= width of type [enabled by default]
/home/ralf/src/linux/linux-mips/arch/mips/include/asm/bitops.h:583:2: warning: left shift count >= width of type [enabled by default]
/home/ralf/src/linux/linux-mips/arch/mips/include/asm/bitops.h:587:2: warning: left shift count >= width of type [enabled by default]
/home/ralf/src/linux/linux-mips/arch/mips/include/asm/bitops.h:591:2: warning: left shift count >= width of type [enabled by default]
In file included from /home/ralf/src/linux/linux-mips/arch/mips/include/asm/page.h:46:0,
from /home/ralf/src/linux/linux-mips/arch/mips/include/asm/compat.h:8,
from include/linux/compat.h:18,
from arch/mips/kernel/asm-offsets.c:11:
/home/ralf/src/linux/linux-mips/arch/mips/include/asm/io.h: In function ‘phys_to_virt’:
/home/ralf/src/linux/linux-mips/arch/mips/include/asm/io.h:136:9: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
/home/ralf/src/linux/linux-mips/arch/mips/include/asm/io.h: In function ‘isa_bus_to_virt’:
/home/ralf/src/linux/linux-mips/arch/mips/include/asm/io.h:149:9: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
/home/ralf/src/linux/linux-mips/arch/mips/include/asm/io.h: In function ‘outq’:
/home/ralf/src/linux/linux-mips/arch/mips/include/asm/io.h:444:1: error: size of unnamed array is negative
/home/ralf/src/linux/linux-mips/arch/mips/include/asm/io.h: In function ‘inq’:
/home/ralf/src/linux/linux-mips/arch/mips/include/asm/io.h:444:1: error: size of unnamed array is negative
/home/ralf/src/linux/linux-mips/arch/mips/include/asm/io.h: In function ‘outq_p’:
/home/ralf/src/linux/linux-mips/arch/mips/include/asm/io.h:444:1: error: size of unnamed array is negative
/home/ralf/src/linux/linux-mips/arch/mips/include/asm/io.h: In function ‘inq_p’:
/home/ralf/src/linux/linux-mips/arch/mips/include/asm/io.h:444:1: error: size of unnamed array is negative
/home/ralf/src/linux/linux-mips/arch/mips/include/asm/io.h: In function ‘__mem_outq’:
/home/ralf/src/linux/linux-mips/arch/mips/include/asm/io.h:444:1: error: size of unnamed array is negative
/home/ralf/src/linux/linux-mips/arch/mips/include/asm/io.h: In function ‘__mem_inq’:
/home/ralf/src/linux/linux-mips/arch/mips/include/asm/io.h:444:1: error: size of unnamed array is negative
/home/ralf/src/linux/linux-mips/arch/mips/include/asm/io.h: In function ‘__mem_outq_p’:
/home/ralf/src/linux/linux-mips/arch/mips/include/asm/io.h:444:1: error: size of unnamed array is negative
/home/ralf/src/linux/linux-mips/arch/mips/include/asm/io.h: In function ‘__mem_inq_p’:
/home/ralf/src/linux/linux-mips/arch/mips/include/asm/io.h:444:1: error: size of unnamed array is negative
In file included from /home/ralf/src/linux/linux-mips/arch/mips/include/asm/pgtable.h:15:0,
from include/linux/mm.h:42,
from arch/mips/kernel/asm-offsets.c:14:
/home/ralf/src/linux/linux-mips/arch/mips/include/asm/pgtable-64.h: In function ‘mk_swap_pte’:
/home/ralf/src/linux/linux-mips/arch/mips/include/asm/pgtable-64.h:273:1: warning: left shift count >= width of type [enabled by default]
/home/ralf/src/linux/linux-mips/arch/mips/include/asm/pgtable-64.h:273:1: warning: left shift count >= width of type [enabled by default]
In file included from arch/mips/kernel/asm-offsets.c:14:0:
include/linux/mm.h: In function ‘virt_to_head_page’:
include/linux/mm.h:393:9: warning: right shift count >= width of type [enabled by default]
In file included from arch/mips/kernel/asm-offsets.c:14:0:
include/linux/mm.h: In function ‘lowmem_page_address’:
include/linux/mm.h:723:9: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
make[1]: *** [arch/mips/kernel/asm-offsets.s] Error 1
make: *** [archprepare] Error 2
Not yet sure what the fix should be.
Ralf
next prev parent reply other threads:[~2011-11-07 20:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-25 1:03 [PATCH] Kbuild: append missing-syscalls to the default target list Arnaud Lacombe
2011-09-09 11:55 ` Michal Marek
2011-09-14 5:17 ` Arnaud Lacombe
2011-11-01 23:22 ` Michal Marek
2011-11-07 20:44 ` Ralf Baechle [this message]
2011-11-07 21:19 ` Michal Marek
2011-11-07 23:33 ` Ralf Baechle
2011-11-08 8:25 ` Michal Marek
2011-11-08 9:53 ` Ralf Baechle
2011-11-08 18:21 ` David Daney
2011-11-08 18:21 ` David Daney
2011-11-08 22:30 ` Michal Marek
2011-11-09 9:54 ` Ralf Baechle
2011-11-09 13:43 ` Michal Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111107204448.GA9949@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=ddaney@caviumnetworks.com \
--cc=lacombar@gmail.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=mmarek@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.