From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org
Cc: Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
stable@vger.kernel.org, Ilya Dryomov <idryomov@gmail.com>
Subject: [PATCH 01/10] tracing: fix event_subsystem ref counting
Date: Mon, 07 Nov 2011 20:29:40 -0500 [thread overview]
Message-ID: <20111108013036.621852474@goodmis.org> (raw)
In-Reply-To: 20111108012939.372220547@goodmis.org
[-- Attachment #1: Type: text/plain, Size: 1268 bytes --]
From: Ilya Dryomov <idryomov@gmail.com>
Fix a bug introduced by e9dbfae5, which prevents event_subsystem from
ever being released.
Ref_count was added to keep track of subsystem users, not for counting
events. Subsystem is created with ref_count = 1, so there is no need to
increment it for every event, we have nr_events for that. Fix this by
touching ref_count only when we actually have a new user -
subsystem_open().
Cc: stable@vger.kernel.org
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Link: http://lkml.kernel.org/r/1320052062-7846-1-git-send-email-idryomov@gmail.com
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---
kernel/trace/trace_events.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c
index 581876f..c212a7f 100644
--- a/kernel/trace/trace_events.c
+++ b/kernel/trace/trace_events.c
@@ -1078,7 +1078,6 @@ event_subsystem_dir(const char *name, struct dentry *d_events)
/* First see if we did not already create this dir */
list_for_each_entry(system, &event_subsystems, list) {
if (strcmp(system->name, name) == 0) {
- __get_system(system);
system->nr_events++;
return system->entry;
}
--
1.7.7
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2011-11-08 1:32 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-08 1:29 [PATCH 00/10] [GIT PULL] tracing: various fixes Steven Rostedt
2011-11-08 1:29 ` Steven Rostedt [this message]
2011-11-08 1:29 ` [PATCH 02/10] tracing: Restore system filter behavior Steven Rostedt
2011-11-08 1:29 ` [PATCH 03/10] tracing: Add boiler plate for subsystem filter Steven Rostedt
2011-11-08 1:29 ` [PATCH 04/10] tracing: update Documentation on max preds limit Steven Rostedt
2011-11-08 1:29 ` [PATCH 05/10] lockdep: Show subclass in pretty print of lockdep output Steven Rostedt
2011-11-08 1:29 ` [PATCH 06/10] ftrace: Remove force undef config value left for testing Steven Rostedt
2011-11-08 1:29 ` [PATCH 07/10] jump_label: jump_label_inc may return before the code is patched Steven Rostedt
2011-11-08 1:29 ` [PATCH 08/10] perf: Fix parsing of __print_flags() in TP_printk() Steven Rostedt
2011-11-08 1:29 ` [PATCH 09/10] ftrace: Fix hash record accounting bug Steven Rostedt
2011-11-08 1:29 ` [PATCH 10/10] tracing/latency: Fix header output for latency tracers Steven Rostedt
2011-11-11 8:33 ` [PATCH 00/10] [GIT PULL] tracing: various fixes Ingo Molnar
2011-11-29 21:33 ` Steven Rostedt
2011-12-03 9:20 ` Ingo Molnar
2011-12-05 0:31 ` Steven Rostedt
2011-12-05 9:47 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111108013036.621852474@goodmis.org \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=idryomov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.