All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
To: Frederic Weisbecker <fweisbec-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Tim Hockin <thockin-Rl2oBbRerpQdnm+yROfE0A@public.gmane.org>,
	Ben Blum <bblum-OM76b2Iv3yLQjUSlxSEPGw@public.gmane.org>,
	Paul Menage <paul-inf54ven1CmVyaH7bEyXVA@public.gmane.org>,
	LKML <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Cgroups <cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Containers
	<containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>
Subject: Re: [PATCH -mm] cgroup: Fix task counter common ancestor logic
Date: Tue, 8 Nov 2011 13:51:11 -0800	[thread overview]
Message-ID: <20111108135111.6a74f1d2.akpm@linux-foundation.org> (raw)
In-Reply-To: <1320765670-14181-1-git-send-email-fweisbec-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

On Tue,  8 Nov 2011 16:21:10 +0100
Frederic Weisbecker <fweisbec-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:

> To solve this, keep the original cgroup of each thread in the thread
> group cached in the flex array and pass it to can_attach_task()/attach_task()
> and cancel_attach_task() so that the correct common ancestor between the old
> and new cgroup can be safely retrieved for each task.

OK, thanks.

We need to work out what to do with this patchset.  ie: should we merge
it.  I'm not sure that the case has been made?

Let's please drag this thing onto the table and poke at it for a while.
Probably everyone has forgotten everything so we'll need to start
again, sorry.  Perhaps you can (re)start proceedings by telling us why
it's useful to our users and why we should merge it?


Some mental notes:

Tim says it would be useful for the things he's doing but doesn't
appear to have confirmed/tested that.

Kay has said that it would not be useful for his plumber's wishlist
item, which is a shame.

I seem to recall complaining that it doesn't address the forkbomb issue
for non-cgroups setups, so the forkbomb issue remains unaddressed.

WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Ben Blum <bblum@andrew.cmu.edu>, Li Zefan <lizf@cn.fujitsu.com>,
	Paul Menage <paul@paulmenage.org>,
	Tim Hockin <thockin@hockin.org>, Tejun Heo <tj@kernel.org>,
	Containers <containers@lists.linux-foundation.org>,
	Cgroups <cgroups@vger.kernel.org>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Subject: Re: [PATCH -mm] cgroup: Fix task counter common ancestor logic
Date: Tue, 8 Nov 2011 13:51:11 -0800	[thread overview]
Message-ID: <20111108135111.6a74f1d2.akpm@linux-foundation.org> (raw)
In-Reply-To: <1320765670-14181-1-git-send-email-fweisbec@gmail.com>

On Tue,  8 Nov 2011 16:21:10 +0100
Frederic Weisbecker <fweisbec@gmail.com> wrote:

> To solve this, keep the original cgroup of each thread in the thread
> group cached in the flex array and pass it to can_attach_task()/attach_task()
> and cancel_attach_task() so that the correct common ancestor between the old
> and new cgroup can be safely retrieved for each task.

OK, thanks.

We need to work out what to do with this patchset.  ie: should we merge
it.  I'm not sure that the case has been made?

Let's please drag this thing onto the table and poke at it for a while.
Probably everyone has forgotten everything so we'll need to start
again, sorry.  Perhaps you can (re)start proceedings by telling us why
it's useful to our users and why we should merge it?


Some mental notes:

Tim says it would be useful for the things he's doing but doesn't
appear to have confirmed/tested that.

Kay has said that it would not be useful for his plumber's wishlist
item, which is a shame.

I seem to recall complaining that it doesn't address the forkbomb issue
for non-cgroups setups, so the forkbomb issue remains unaddressed.



  parent reply	other threads:[~2011-11-08 21:51 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-08 15:21 [PATCH -mm] cgroup: Fix task counter common ancestor logic Frederic Weisbecker
2011-11-08 15:21 ` Frederic Weisbecker
     [not found] ` <1320765670-14181-1-git-send-email-fweisbec-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2011-11-08 21:51   ` Andrew Morton [this message]
2011-11-08 21:51     ` Andrew Morton
     [not found]     ` <20111108135111.6a74f1d2.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2011-11-08 23:58       ` KAMEZAWA Hiroyuki
2011-11-08 23:58         ` KAMEZAWA Hiroyuki
2011-11-24 13:24       ` Frederic Weisbecker
2011-11-24 13:24       ` Frederic Weisbecker
2011-11-24 13:24         ` Frederic Weisbecker
     [not found]         ` <20111124132442.GA18579-oHC15RC7JGTpAmv0O++HtFaTQe2KTcn/@public.gmane.org>
2011-12-13 20:44           ` Daniel J Walsh
2011-12-13 20:44           ` Daniel J Walsh
2011-12-13 20:44             ` Daniel J Walsh
     [not found]             ` <4EE7B926.9030702-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2011-12-13 23:22               ` Daniel P. Berrange
2011-12-13 23:22               ` Daniel P. Berrange
2011-12-13 23:22                 ` Daniel P. Berrange

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111108135111.6a74f1d2.akpm@linux-foundation.org \
    --to=akpm-de/tnxtf+jlsfhdxvbkv3wd2fqjk+8+b@public.gmane.org \
    --cc=bblum-OM76b2Iv3yLQjUSlxSEPGw@public.gmane.org \
    --cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=fweisbec-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=paul-inf54ven1CmVyaH7bEyXVA@public.gmane.org \
    --cc=thockin-Rl2oBbRerpQdnm+yROfE0A@public.gmane.org \
    --cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.