From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Alessandro Suardi <alessandro.suardi@gmail.com>,
platform-driver-x86@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Linux 3.2-rc1
Date: Tue, 8 Nov 2011 20:15:07 +0000 [thread overview]
Message-ID: <20111108201507.GA16883@srcf.ucam.org> (raw)
In-Reply-To: <CA+55aFyojS9n=jP07X2BcxZ5z8YkBaZnNnthTs8xBkdtBdK1XA@mail.gmail.com>
On Tue, Nov 08, 2011 at 12:13:16PM -0800, Linus Torvalds wrote:
> On Tue, Nov 8, 2011 at 6:53 AM, Alessandro Suardi
> <alessandro.suardi@gmail.com> wrote:
> >
> > Dell laptop support (and I'd suspect other drivers using LED support)
> > doesn't build with undefined LED-related functions, as in:
> >
> > ERROR: "led_classdev_unregister" [drivers/platform/x86/dell-laptop.ko]
> > undefined!
> > ERROR: "led_classdev_register" [drivers/platform/x86/dell-laptop.ko] undefined!
> > make[1]: *** [__modpost] Error 1
> > make: *** [modules] Error 2
> >
> > It's enough to configure NEW_LEDS (unneeded in 3.1.0) to allow the build to go
> > through; maybe NEW_LEDS should be auto-selected in Kconfig by drivers that
> > make use of led_classdev_* functions ?
>
> Yeah, that sounds like the right fix. There are a lot of "select
> NEW_LEDS" around already, but apparently not the Dell driver.
Sorry, missed that change. Yes, that sounds completely reasonable.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2011-11-08 20:15 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-08 2:10 Linux 3.2-rc1 Linus Torvalds
2011-11-08 3:12 ` Al Viro
2011-11-08 4:26 ` Linus Torvalds
2011-11-08 10:52 ` Geert Uytterhoeven
2011-11-08 6:50 ` Nicholas A. Bellinger
2011-11-08 13:43 ` Udo Steinberg
2011-11-08 14:47 ` Ming Lei
2011-11-08 22:10 ` Rafael J. Wysocki
2011-11-08 14:53 ` Alessandro Suardi
2011-11-08 20:13 ` Linus Torvalds
2011-11-08 20:15 ` Matthew Garrett [this message]
2011-11-08 20:44 ` Linus Torvalds
2011-11-08 14:55 ` Nick Bowler
2011-11-08 20:23 ` Linus Torvalds
2011-11-09 7:40 ` Takashi Iwai
2011-11-09 7:40 ` Takashi Iwai
2011-11-09 12:03 ` Wu Fengguang
2011-11-10 11:57 ` Wu Fengguang
2011-11-10 11:57 ` Wu Fengguang
2011-11-08 19:06 ` Thomas Bächler
2011-11-08 23:00 ` Steven Rostedt
2011-11-08 23:53 ` Linus Torvalds
2011-11-09 8:09 ` Borislav Petkov
2011-11-09 13:11 ` Valdis.Kletnieks
2011-11-09 14:20 ` Paul Rolland
2011-11-09 23:23 ` Linus Torvalds
2011-11-09 17:18 ` Randy Dunlap
2011-11-09 17:28 ` Josh Boyer
2011-11-22 1:41 ` Boaz Harrosh
2011-11-22 16:10 ` Josh Boyer
2011-11-22 18:05 ` Alan Cox
2011-11-22 18:29 ` Boaz Harrosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111108201507.GA16883@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=alessandro.suardi@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.