From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthew Garrett Subject: Re: [PATCH v3 2/2] drivers: i915: Default max backlight brightness value Date: Tue, 8 Nov 2011 22:47:39 +0000 Message-ID: <20111108224739.GA19936@srcf.ucam.org> References: <1320788127-17292-1-git-send-email-sque@chromium.org> <1320788127-17292-2-git-send-email-sque@chromium.org> <20111108214258.GA18672@srcf.ucam.org> <20111108221013.GA19222@srcf.ucam.org> <20111108222805.GA19553@srcf.ucam.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from cavan.codon.org.uk (cavan.codon.org.uk [93.93.128.6]) by gabe.freedesktop.org (Postfix) with ESMTP id C8ACAA0A5A for ; Tue, 8 Nov 2011 14:47:42 -0800 (PST) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Simon Que Cc: intel-gfx@lists.freedesktop.org, olofj@chromium.org, snanda@chromium.org List-Id: intel-gfx@lists.freedesktop.org On Tue, Nov 08, 2011 at 02:41:56PM -0800, Simon Que wrote: > There is a backup kernel partition that can be used for boot. > > Failing that, the system can boot from a recovery image over USB. So absolutely no video code in the firmware at all? Ok. What I'd really rather see here is some generic way for platform-specific code to pass the correct value to the driver. You're already exposing various things via the chromeos-acpi code, can you use that to set things up sensibly? It's obviously possible to use the command line to transfer this information, it's just considered pretty poor style. -- Matthew Garrett | mjg59@srcf.ucam.org