From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthew Garrett Subject: Re: [PATCH v3 2/2] drivers: i915: Default max backlight brightness value Date: Tue, 8 Nov 2011 23:11:34 +0000 Message-ID: <20111108231134.GA20232@srcf.ucam.org> References: <1320788127-17292-1-git-send-email-sque@chromium.org> <1320788127-17292-2-git-send-email-sque@chromium.org> <20111108214258.GA18672@srcf.ucam.org> <20111108221013.GA19222@srcf.ucam.org> <20111108222805.GA19553@srcf.ucam.org> <20111108224739.GA19936@srcf.ucam.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from cavan.codon.org.uk (cavan.codon.org.uk [93.93.128.6]) by gabe.freedesktop.org (Postfix) with ESMTP id ABA7B9EB4A for ; Tue, 8 Nov 2011 15:11:38 -0800 (PST) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Olof Johansson Cc: intel-gfx@lists.freedesktop.org, olofj@chromium.org, snanda@chromium.org, Simon Que List-Id: intel-gfx@lists.freedesktop.org On Tue, Nov 08, 2011 at 03:02:00PM -0800, Olof Johansson wrote: > How about a DMI table check that overrides whatever is setup (or not > setup) from the video bios? We know exactly what platforms need this > so that table would be easy to specify. dmi's horribly unscalable. It's much better to have a communication channel that doesn't require new code for new models of the same platform. > I'm not sure how well this would fit into our platform layer code, it > would be pretty nasty to have to export the default backlight variable > from the i915 driver and modify it from there as well, and I'm sure > noone wants to see any kind of chromeos-specific code paths in the 915 > driver (myself included). Well right now this path is (effectively) chromeos-specific. Refactoring the code so we just have the register readback as a single information source and allow the existing platform-specific code to hook in would be conceptually cleaner. But then maybe this is grotesque over-engineering and we should just hack this case. -- Matthew Garrett | mjg59@srcf.ucam.org