From: "Roedel, Joerg" <Joerg.Roedel@amd.com>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"jbarnes@virtuousgeek.org" <jbarnes@virtuousgeek.org>,
"bhelgaas@google.com" <bhelgaas@google.com>
Subject: Re: [PATCH] pci: More PRI/PASID cleanup
Date: Wed, 9 Nov 2011 10:59:02 +0100 [thread overview]
Message-ID: <20111109095902.GB13213@amd.com> (raw)
In-Reply-To: <1320776406.19116.42.camel@bling.home>
On Tue, Nov 08, 2011 at 11:20:06AM -0700, Alex Williamson wrote:
> My guess is that someone asked why a device would ever expose this table
> if it didn't support enable as a capability. So, I wouldn't be
> surprised if your hardware sets it, but it's probably just as safe to
> assume enable is supported if the PASID table exists.
That is probably true. I suggest that you split the functional change
out of the patch and do only the renaming. I look over the code again
then and change it in a way that works with reality and the spec. Does
that work for you?
Joerg
--
AMD Operating System Research Center
Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632
prev parent reply other threads:[~2011-11-09 9:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-03 3:53 [PATCH] pci: More PRI/PASID cleanup Alex Williamson
2011-11-08 16:28 ` Roedel, Joerg
2011-11-08 16:44 ` Alex Williamson
2011-11-08 17:17 ` Roedel, Joerg
2011-11-08 17:31 ` Alex Williamson
2011-11-08 17:54 ` Roedel, Joerg
2011-11-08 18:20 ` Alex Williamson
2011-11-09 9:59 ` Roedel, Joerg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111109095902.GB13213@amd.com \
--to=joerg.roedel@amd.com \
--cc=alex.williamson@redhat.com \
--cc=bhelgaas@google.com \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.