From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: alex@alex.org.uk, kaber@trash.net, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] netfilter: fix ->nfnl NULL oops
Date: Wed, 9 Nov 2011 15:34:23 +0100 [thread overview]
Message-ID: <20111109143423.GA24158@1984> (raw)
In-Reply-To: <20111108221634.GA13261@p183.telecom.by>
On Wed, Nov 09, 2011 at 01:16:35AM +0300, Alexey Dobriyan wrote:
> Sorry for delay.
>
> I recall myself writing that net->nfnl NULL check is racy or
> something like that (but I can't find this email in archives).
>
> I've read the code once again, and I'm quite sure,
> NULL ->nfnl check is correct if RCU precautions are made.
>
> Regarding ->report check, I think it's bogus.
>
> If there are no listeners, there are NO listeners
> and whether to report back to userspace doesn't matter.
>
> I'm sure I'm missing something obvious here.
>
> Please, review.
Alexey. This is a workaround. We have to make ctnl_notifier
container-aware which is the real problem.
next prev parent reply other threads:[~2011-11-09 14:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-08 22:16 [PATCH] netfilter: fix ->nfnl NULL oops Alexey Dobriyan
2011-11-08 22:50 ` Alex Bligh
2011-11-09 14:35 ` Pablo Neira Ayuso
2011-11-09 19:04 ` Alex Bligh
2011-11-09 14:34 ` Pablo Neira Ayuso [this message]
2011-11-09 19:06 ` Alex Bligh
2011-11-15 9:56 ` Pablo Neira Ayuso
2011-11-15 10:13 ` Alex Bligh
2011-11-15 14:09 ` Pablo Neira Ayuso
2011-11-21 23:39 ` Pablo Neira Ayuso
2011-11-21 23:42 ` Pablo Neira Ayuso
2011-11-21 23:50 ` Alex Bligh
2011-11-22 14:23 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111109143423.GA24158@1984 \
--to=pablo@netfilter.org \
--cc=adobriyan@gmail.com \
--cc=alex@alex.org.uk \
--cc=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.