From: Greg KH <gregkh@suse.de>
To: Tejun Heo <tj@kernel.org>
Cc: Jens Axboe <axboe@kernel.dk>,
"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
Nao Nishijima <nao.nishijima.xt@hitachi.com>,
Kay Sievers <kay.sievers@vrfy.org>,
Alan Cox <alan@linux.intel.com>,
Al Viro <viro@zeniv.linux.org.uk>,
linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: [PATCH] block: Revert "[SCSI] genhd: add a new attribute "alias" in gendisk"
Date: Wed, 9 Nov 2011 08:53:30 -0800 [thread overview]
Message-ID: <20111109165330.GA13326@suse.de> (raw)
In-Reply-To: <20111109162512.GB1260@google.com>
On Wed, Nov 09, 2011 at 08:25:12AM -0800, Tejun Heo wrote:
> This reverts commit a72c5e5eb738033938ab30d6a634b74d1d060f10.
>
> The commit introduced alias for block devices which is intended to be
> used during logging although actual usage hasn't been committed yet.
> This approach adds very limited benefit (raw log might be easier to
> follow) which can be trivially implemented in userland but has a lot
> of problems.
>
> It is much worse than netif renames because it doesn't rename the
> actual device but just adds conveninence name which isn't used
> universally or enforced. Everything internal including device lookup
> and sysfs still uses the internal name and nothing prevents two
> devices from using conflicting alias - ie. sda can have sdb as its
> alias.
>
> This has been nacked by people working on device driver core, block
> layer and kernel-userland interface and shouldn't have been
> upstreamed. Revert it.
>
> http://thread.gmane.org/gmane.linux.kernel/1155104
> http://thread.gmane.org/gmane.linux.scsi/68632
> http://thread.gmane.org/gmane.linux.scsi/69776
>
> Signed-off-by: Tejun Heo <tj@kernel.org>
> Cc: Jens Axboe <axboe@kernel.dk>
> Cc: "James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>
> Cc: Nao Nishijima <nao.nishijima.xt@hitachi.com>
> Cc: Kay Sievers <kay.sievers@vrfy.org>
> Cc: Greg Kroah-Hartman <gregkh@suse.de>
Acked-by: Greg Kroah-Hartman <gregkh@suse.de>
Thanks for reverting this,
greg k-h
next prev parent reply other threads:[~2011-11-09 16:53 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-09 16:25 [PATCH] block: Revert "[SCSI] genhd: add a new attribute "alias" in gendisk" Tejun Heo
2011-11-09 16:25 ` Tejun Heo
2011-11-09 16:53 ` Greg KH [this message]
2011-11-09 17:19 ` Kay Sievers
2011-11-09 17:30 ` James Bottomley
2011-11-09 17:36 ` Greg KH
2011-11-09 17:38 ` Kay Sievers
2011-11-09 19:51 ` Karel Zak
2011-11-09 18:54 ` Jens Axboe
2011-11-10 21:21 ` Jeff Garzik
2011-11-11 14:50 ` Nao Nishijima
2011-11-11 14:50 ` Nao Nishijima
2011-11-11 17:36 ` Greg KH
2011-11-11 19:09 ` Douglas Gilbert
2011-11-24 12:21 ` Bernd Schubert
2011-11-24 12:21 ` Bernd Schubert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111109165330.GA13326@suse.de \
--to=gregkh@suse.de \
--cc=James.Bottomley@HansenPartnership.com \
--cc=alan@linux.intel.com \
--cc=axboe@kernel.dk \
--cc=kay.sievers@vrfy.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=nao.nishijima.xt@hitachi.com \
--cc=tj@kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.