From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH 1/5] ASoC: ak4642: add ak4642_set_bias_level() Date: Thu, 10 Nov 2011 11:27:42 +0000 Message-ID: <20111110112741.GC29931@opensource.wolfsonmicro.com> References: <87y5vsqxiz.wl%kuninori.morimoto.gx@renesas.com> <87bosk4cdw.wl%kuninori.morimoto.gx@renesas.com> <87aa844ccp.wl%kuninori.morimoto.gx@renesas.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from opensource.wolfsonmicro.com (opensource.wolfsonmicro.com [80.75.67.52]) by alsa0.perex.cz (Postfix) with ESMTP id 474C8103AB8 for ; Thu, 10 Nov 2011 12:27:44 +0100 (CET) Content-Disposition: inline In-Reply-To: <87aa844ccp.wl%kuninori.morimoto.gx@renesas.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Kuninori Morimoto Cc: Linux-ALSA , Kuninori Morimoto , Liam Girdwood List-Id: alsa-devel@alsa-project.org On Thu, Nov 10, 2011 at 12:21:13AM -0800, Kuninori Morimoto wrote: > + switch (level) { > + case SND_SOC_BIAS_OFF: > + snd_soc_write(codec, PW_MGMT1, 0x00); > + break; > + default: > + snd_soc_update_bits(codec, PW_MGMT1, PMVCM, PMVCM); > + } Should have a break; here for coding style.