From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Leon Romanovsky <leon@leon.nu>
Cc: alsa-devel@alsa-project.org, Andrey Danin <danindrey@mail.ru>,
lrg@ti.com
Subject: Re: [PATCH v4] ASoC: Add new Realtek ALC5632 CODEC driver.
Date: Thu, 10 Nov 2011 13:03:23 +0000 [thread overview]
Message-ID: <20111110130323.GE3832@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <CALq1K=KJ8EytOmfwOaw_pU2B5Cpv7Ar=iE1kL=QTj=mttGxK9g@mail.gmail.com>
On Thu, Nov 10, 2011 at 02:35:42PM +0200, Leon Romanovsky wrote:
> On Thu, Nov 10, 2011 at 14:11, Mark Brown
> > Ideally you should convert the driver over to work with the regmap API
> > and make use of the cache code it provides. This is going to be
> > required at some point in the future and would mean that you could use
> > the same register I/O functionality here where you're identifying the
> > device (which is definitely good practice).
> If it possible, I would prefer to wait with this. I'll not be able to
> test the regmap interface properly because it was implemented for the
> 3.0 tree, and my development machine doesn't support it yet.
As it's an entirely new subsystem it should be really easy to backport
if you just copy the code into the older kernel.
prev parent reply other threads:[~2011-11-10 13:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-05 10:38 [PATCH v4] ASoC: Add new Realtek ALC5632 CODEC driver leon
2011-11-10 12:11 ` Mark Brown
2011-11-10 12:35 ` Leon Romanovsky
2011-11-10 13:03 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111110130323.GE3832@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=danindrey@mail.ru \
--cc=leon@leon.nu \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.