From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anton Vorontsov Subject: Re: [PATCH] s3c-adc-battery: Add naive POWER_SUPPLY_PROP_PRESENT implementation Date: Thu, 10 Nov 2011 17:30:52 +0400 Message-ID: <20111110133052.GA31381@oksana.dev.rtsoft.ru> References: <201111100956.43979.heiko@sntech.de> <1320923106.2594.0.camel@anarsoul-laptop.Home> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <1320923106.2594.0.camel@anarsoul-laptop.Home> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-pm-bounces@lists.linux-foundation.org Errors-To: linux-pm-bounces@lists.linux-foundation.org To: Vasily Khoruzhick Cc: Linux PM mailing list , David Woodhouse , linux-kernel@vger.kernel.org List-Id: linux-pm@vger.kernel.org T24gVGh1LCBOb3YgMTAsIDIwMTEgYXQgMDI6MDU6MDZQTSArMDMwMCwgVmFzaWx5IEtob3J1emhp Y2sgd3JvdGU6Cj4gT24gVGh1LCAyMDExLTExLTEwIGF0IDA5OjU2ICswMTAwLCBIZWlrbyBTdMO8 Ym5lciB3cm90ZToKPiA+IFVzZXJzcGFjZSBwcm9ncmFtcyBsaWtlIHVwb3dlciBzZWVtIHRvIGRl cGVuZCBvbiB0aGUgcHJlc2VuY2Ugb2YgdGhlCj4gPiBQT1dFUl9TVVBQTFlfUFJPUF9QUkVTRU5U IHByb3BlcnR5Lgo+ID4gCj4gPiBUaGUgcmVhbCBwcmVzZW5jZSBvZiB0aGUgYmF0dGVyeSBjYW5u b3QgYmUgc2Vuc2VkIGFuZCBhbGwgb3RoZXIKPiA+IHJvdXRpbmVzIG9mIHMzYy1hZGMtYmF0dGVy eSBzaW1wbHkgZXhwZWN0IGl0IHRvIGJlIHByZXNlbnQuCj4gPiAKPiA+IFRoZXJlZm9yZSB3ZSBz aW1wbHkgcmV0dXJuIDEsIHVubGVzcyB0aGUgYmF0dGVyeSBzdHJ1Y3QgaXMgbm90IHByZXNlbnQg YXQgYWxsLgo+IAo+IExvb2tzIE9LIGZvciBtZSwKPiAKPiA+IFNpZ25lZC1vZmYtYnk6IEhlaWtv IFN0dWVibmVyIDxoZWlrb0BzbnRlY2guZGU+Cj4gQWNrZWQtYnk6IFZhc2lseSBLaG9ydXpoaWNr IDxhbmFyc291bEBnbWFpbC5jb20+CgpJIGRpc2FncmVlLiBJZiB0aGUgZHJpdmVyIGJlaGF2ZXMg bGlrZSB0aGUgaGFyZHdhcmUgZG9lcyBub3Qgc3VwcG9ydApob3QtcGx1Z2dhYmxlIGNlbGxzLCB0 aGVuIHByZXNlbnQgcHJvcGVydHkgaXMgbm90IG5lY2Vzc2FyeS4KClVwb3dlcmQgc2hvdWxkIGxv b2sgYXQgdGhlICdwcmVzZW50JyBvbmx5IGlmIGl0IGlzIHRoZXJlOyBhbmQgaWYgaXQKaXMgbm90 LCBjZWxscyBhc3N1bWVkIHRvIGJlIGFsd2F5cyBwcmVzZW50LgoKWy4uXQo+ID4gIAlpZiAoIWJh dCkgewo+ID4gKwkJaWYgKHBzcCA9PSBQT1dFUl9TVVBQTFlfUFJPUF9QUkVTRU5UKSB7Cj4gPiAr CQkJdmFsLT5pbnR2YWwgPSAwOwo+ID4gKwkJCXJldHVybiAwOwo+ID4gKwkJfQo+ID4gKwo+ID4g IAkJZGV2X2Vycihwc3ktPmRldiwgIiVzOiBubyBiYXR0ZXJ5IGluZm9zID8hXG4iLCBfX2Z1bmNf Xyk7CgpBbmQgaW4gdGhpcyBjYXNlIHRoYXQgZGV2X2VycigpIHRlbGxzIHRoYXQgZWl0aGVyIGhh cmR3YXJlIGRvZXMgbm90CnN1cHBvcnQgaG90LXBsdWdnYWJsZSBjZWxscywgb3IgZHJpdmVyIGRv ZXMgbm90IGhhbmRsZSB0aGlzIGNhc2U7IHdoaWNoCmlzIGFjdHVhbGx5IHRoZSBzYW1lIGZyb20g dGhlIHVzZXJzcGFjZSBwb2ludCBvZiB2aWV3LgoKU28sIHRoZSBwcm9ibGVtIGlzIGluIHVwb3dl cmQsIG5vdCB0aGlzIGRyaXZlci4KClRoYW5rcywKCi0tIApBbnRvbiBWb3JvbnRzb3YKRW1haWw6 IGNib3VhdG1haWxydUBnbWFpbC5jb20KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KbGludXgtcG0gbWFpbGluZyBsaXN0CmxpbnV4LXBtQGxpc3RzLmxpbnV4 LWZvdW5kYXRpb24ub3JnCmh0dHBzOi8vbGlzdHMubGludXhmb3VuZGF0aW9uLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2xpbnV4LXBt From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934511Ab1KJNa6 (ORCPT ); Thu, 10 Nov 2011 08:30:58 -0500 Received: from mail-ww0-f44.google.com ([74.125.82.44]:44205 "EHLO mail-ww0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757180Ab1KJNa4 (ORCPT ); Thu, 10 Nov 2011 08:30:56 -0500 Date: Thu, 10 Nov 2011 17:30:52 +0400 From: Anton Vorontsov To: Vasily Khoruzhick Cc: Heiko =?utf-8?Q?St=C3=BCbner?= , David Woodhouse , linux-kernel@vger.kernel.org, Linux PM mailing list Subject: Re: [PATCH] s3c-adc-battery: Add naive POWER_SUPPLY_PROP_PRESENT implementation Message-ID: <20111110133052.GA31381@oksana.dev.rtsoft.ru> References: <201111100956.43979.heiko@sntech.de> <1320923106.2594.0.camel@anarsoul-laptop.Home> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1320923106.2594.0.camel@anarsoul-laptop.Home> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 10, 2011 at 02:05:06PM +0300, Vasily Khoruzhick wrote: > On Thu, 2011-11-10 at 09:56 +0100, Heiko Stübner wrote: > > Userspace programs like upower seem to depend on the presence of the > > POWER_SUPPLY_PROP_PRESENT property. > > > > The real presence of the battery cannot be sensed and all other > > routines of s3c-adc-battery simply expect it to be present. > > > > Therefore we simply return 1, unless the battery struct is not present at all. > > Looks OK for me, > > > Signed-off-by: Heiko Stuebner > Acked-by: Vasily Khoruzhick I disagree. If the driver behaves like the hardware does not support hot-pluggable cells, then present property is not necessary. Upowerd should look at the 'present' only if it is there; and if it is not, cells assumed to be always present. [..] > > if (!bat) { > > + if (psp == POWER_SUPPLY_PROP_PRESENT) { > > + val->intval = 0; > > + return 0; > > + } > > + > > dev_err(psy->dev, "%s: no battery infos ?!\n", __func__); And in this case that dev_err() tells that either hardware does not support hot-pluggable cells, or driver does not handle this case; which is actually the same from the userspace point of view. So, the problem is in upowerd, not this driver. Thanks, -- Anton Vorontsov Email: cbouatmailru@gmail.com