All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Guinot <simon@sequanux.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mvgbe: remove setting of ethaddr within the driver
Date: Thu, 10 Nov 2011 15:21:53 +0100	[thread overview]
Message-ID: <20111110142152.GC29864@kw.sim.vm.gnt> (raw)
In-Reply-To: <20111110120159.997C113BE0E2@gemini.denx.de>

Hi Wolfgang,

On Thu, Nov 10, 2011 at 01:01:59PM +0100, Wolfgang Denk wrote:
> Dear Simon Guinot,
> 
> In message <20111110110608.GB29864@kw.sim.vm.gnt> you wrote:
> > 
> > > > Let's remove this broken code.
> > > 
> > > This is exactly part of this patch ([PATCH] mvgbe: remove setting of
> > > ethaddr within the driver). This part, while ACK'ed by Mike, was NAK'ed by
> > > Prafulla.
> >
> > As some boards are relying on this broken code, maybe you should provide
> > an alternative ? I could be wrong, but it seems to me that just removing
> > the code is not enough.
> 
> Which exact boards are these? And how exactly are these relying on the
> broken code?

I can't list this boards exactly. For sure, I can say that the
LaCie boards (netspace_v2 and cie) are concerned.

For this boards a random MAC address is used and the computation is
performed by the driver mvgbe. If this code is simply removed, the
network initialization for this boards will break.

I suspect a lot of Marvell boards from being in the same case.

Regards,

Simon
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
Url : http://lists.denx.de/pipermail/u-boot/attachments/20111110/49719d4e/attachment.pgp 

  reply	other threads:[~2011-11-10 14:21 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-07 22:08 [U-Boot] [PATCH] mvgbe: remove setting of ethaddr within the driver Michael Walle
2011-11-08  7:18 ` Prafulla Wadaskar
2011-11-08 13:58   ` Mike Frysinger
2011-11-08 14:10     ` Wolfgang Denk
2011-11-08 13:57 ` Mike Frysinger
2011-11-08 13:45   ` Michael Walle
2011-11-08 14:54     ` Mike Frysinger
2011-11-08 15:17     ` Wolfgang Denk
2011-11-08 17:34       ` Michael Walle
2011-11-08 19:28         ` Wolfgang Denk
2011-11-08 22:30           ` Michael Walle
2011-11-08 22:52             ` Wolfgang Denk
2011-11-08 23:26               ` Michael Walle
2011-11-08 23:38                 ` Wolfgang Denk
2011-11-09  8:31                 ` Michael Walle
2011-11-09 17:34                   ` Michael Walle
2011-11-09 19:27                     ` Wolfgang Denk
2011-11-10  9:15                       ` Michael Walle
2011-11-10 11:06                         ` Simon Guinot
2011-11-10 12:01                           ` Wolfgang Denk
2011-11-10 14:21                             ` Simon Guinot [this message]
2011-11-10 15:53                               ` Wolfgang Denk
2011-11-10 16:30                                 ` Valentin Longchamp
2011-11-10 17:00                                   ` Holger Brunck
2011-11-10 17:08                                   ` Mike Frysinger
2011-11-10 17:09                               ` Mike Frysinger
2011-11-10 17:54                                 ` Simon Guinot
2011-11-10 17:46                               ` Michael Walle
2011-11-10 11:44                         ` Wolfgang Denk
2011-11-16 20:15                           ` Michael Walle
2011-11-16 20:26                             ` Wolfgang Denk
2011-11-17  8:58                               ` Prafulla Wadaskar
2011-11-17 10:45                                 ` Wolfgang Denk
2011-11-17 22:52                                 ` [U-Boot] [PATCH v2] " Michael Walle
2011-11-19  3:58                                   ` Mike Frysinger
2011-11-21  4:39                                   ` Prafulla Wadaskar
2011-12-20 21:55                                   ` Wolfgang Denk
2011-12-20 21:57                                   ` Wolfgang Denk
2011-11-08 20:49         ` [U-Boot] [PATCH] " Mike Frysinger
2011-11-08 22:45           ` Michael Walle
2011-11-09  5:36             ` Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111110142152.GC29864@kw.sim.vm.gnt \
    --to=simon@sequanux.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.