Re: [PATCH] ASoC: sta32x: add workaround for ESD reset issue

[Johannes Stezenbach <js@sig21.net>]

On Wed, Nov 09, 2011 at 11:32:57PM +0000, Mark Brown wrote:
> On Wed, Nov 09, 2011 at 06:34:19PM +0100, Johannes Stezenbach wrote:
> > On Wed, Nov 09, 2011 at 02:36:47PM +0000, Mark Brown wrote:
> 
> > > Given that the driver already supports powering the device down it may
> > > also be sufficient to simply enable idle_bias_off and assume that if the
> > > device resets the application will get sufficiently upset to restart
> > > things anyway.
> 
> > Unfortunately the app won't notice, the PXA I2S interface will
> > happily push the audio data to the codec which will be muted
> > without the app knowing it since the register cache will tell
> > something different.
> 
> Yeah, but if it suddenly stops in the middle of playback then that'll
> tend to register with users and if you keep it powered off at all other
> times.

Hm, the goal is to fix the issue without user interaction.
The app will keep the device open and will play back
without noticing the problem.

> > > > +	for (i = 0; i < numcoef && (index + (i + 1) * 3 < STA32X_COEF_COUNT); i++)
> > > > +		sta32x->coef_shadow[index + i] =
> > > > +			  (ucontrol->value.bytes.data[3 * i    ] << 16)
> > > > +			| (ucontrol->value.bytes.data[3 * i + 1] << 8)
> > > > +			| (ucontrol->value.bytes.data[3 * i + 2]);
> 
> > > Does this need to be done when restoring to _STANDBY as well?
> 
> > No, all registers and coefs are preserved until hw reset or power loss.
> 
> Right, but the bias level management is disabling the regulators for the
> device so power loss may happen then and _STANDBY is also used to resume
> the device after suspend when power loss may also occur.

Ah, you're right, if the system cuts power to the sta32x during
standby we need to restore the coef RAM after resume.  How I
see where my code is buggy.  I also see what you mean about
using idle_bias_off to restore the settings, namely

	level = codec->dapm.bias_level;
	BUG_ON(level == SND_SOC_BIAS_OFF);
	sta32x_set_bias_level(codec, SND_SOC_BIAS_OFF);
	sta32x_set_bias_level(codec, SND_SOC_BIAS_STANDBY);
	if (level > SND_SOC_BIAS_STANDBY);
		sta32x_set_bias_level(codec, SND_SOC_BIAS_PREPARE);
	if (level > SND_SOC_BIAS_PREPARE);
		sta32x_set_bias_level(codec, SND_SOC_BIAS_ON);

Right?

I'll work on a new version of the patch and send it after
it's been put through testing by Sven.


Thanks for the review!

Johannes