From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nadav Har'El Subject: Re: [PATCH 01/10] nEPT: Module option Date: Thu, 10 Nov 2011 17:14:05 +0200 Message-ID: <20111110151405.GC3327@fermat.math.technion.ac.il> References: <1320919040-nyh@il.ibm.com> <201111100958.pAA9wMeL019600@rice.haifa.ibm.com> <4EBBC22D.8090409@redhat.com> <20111110142115.GA3327@fermat.math.technion.ac.il> <4EBBE1CE.5060702@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org, "Roedel, Joerg" , owasserm@redhat.com, abelg@il.ibm.com To: Avi Kivity Return-path: Received: from mailgw12.technion.ac.il ([132.68.225.12]:12899 "EHLO mailgw12.technion.ac.il" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934282Ab1KJPOk (ORCPT ); Thu, 10 Nov 2011 10:14:40 -0500 Content-Disposition: inline In-Reply-To: <4EBBE1CE.5060702@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Thu, Nov 10, 2011, Avi Kivity wrote about "Re: [PATCH 01/10] nEPT: Module option": > > By "this", do you mean without the "nested_ept" option, or without the > > hypothetical "EPT on shadow page tables" feature? > > Er, both. The feature should be controlled on a per-guest basis, not > per host. >.. > It's just redundant, since we do need a per-guest control. I agreed that per-guest control would have been nicer, but since we don't have an API for specifying that per guest since EPT is not, unfortunately, a CPUID feature, I thought that at least a host-level flag would be useful. Why would it be useful? I agree it isn't the most important option since sliced bread, but if, for example, one day we discover a bug with nested EPT, L0 can disable it for all L1 guests and basically force them to use shadow page tables on EPT. It was also useful for me to have this option for benchmarking, because I can force back the old shadow-on-EPT method with just a single option in L0 (instead of needing to give "ept=0" option in L1s). If you really don't like the existance of this option, I can easily remove it of course. -- Nadav Har'El | Thursday, Nov 10 2011, nyh@math.technion.ac.il |----------------------------------------- Phone +972-523-790466, ICQ 13349191 |Guarantee: this email is 100% free of http://nadav.harel.org.il |magnetic monopoles, or your money back!