diff for duplicates of <20111110161331.GG3083@suse.de> diff --git a/a/1.txt b/N1/1.txt index df7ea1c..30c8e67 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -77,23 +77,23 @@ I can't think of a better name but we can at least improve the comment. > #define __GFP_NO_KSWAPD xxxx > > > -> > /* -> > * High-order allocations do not necessarily loop after -> > * direct reclaim and reclaim/compaction depends on -> > * compaction being called after reclaim so call directly if -> > * necessary -> > */ -> > page = __alloc_pages_direct_compact(gfp_mask, order, -> > zonelist, high_zoneidx, -> > nodemask, -> > alloc_flags, preferred_zone, -> > migratetype, &did_some_progress, -> > sync_migration); +> > /* +> > * High-order allocations do not necessarily loop after +> > * direct reclaim and reclaim/compaction depends on +> > * compaction being called after reclaim so call directly if +> > * necessary +> > */ +> > page = __alloc_pages_direct_compact(gfp_mask, order, +> > zonelist, high_zoneidx, +> > nodemask, +> > alloc_flags, preferred_zone, +> > migratetype, &did_some_progress, +> > sync_migration); > > > > __GFP_NORETRY is used in a bunch of places and while the most > > of them are not high-order, some of them potentially are like in > > sound/core/memalloc.c. Using __GFP_NO_KSWAPD as the flag allows -> > these callers to continue using sync compaction. It could be argued +> > these callers to continue using sync compaction. It could be argued > > Okay. If I was biased first, I have opposed this comment because they > might think __GFP_NORETRY is very latency sensitive. @@ -269,3 +269,10 @@ index 6e8ecb6..a3b5da6 100644 /* Try direct reclaim and then allocating */ page = __alloc_pages_direct_reclaim(gfp_mask, order, + +-- +To unsubscribe, send a message with 'unsubscribe linux-mm' in +the body to majordomo@kvack.org. For more info on Linux MM, +see: http://www.linux-mm.org/ . +Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ +Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> diff --git a/a/content_digest b/N1/content_digest index 86edbfd..8e18689 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -93,23 +93,23 @@ "> #define __GFP_NO_KSWAPD xxxx\n" "> \n" "> >\n" - "> > \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240/*\n" - "> > \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 * High-order allocations do not necessarily loop after\n" - "> > \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 * direct reclaim and reclaim/compaction depends on\n" - "> > \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 * compaction being called after reclaim so call directly if\n" - "> > \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 * necessary\n" - "> > \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 */\n" - "> > \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240page = __alloc_pages_direct_compact(gfp_mask, order,\n" - "> > \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240zonelist, high_zoneidx,\n" - "> > \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240nodemask,\n" - "> > \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240alloc_flags, preferred_zone,\n" - "> > \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240migratetype, &did_some_progress,\n" - "> > \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240sync_migration);\n" + "> > /*\n" + "> > * High-order allocations do not necessarily loop after\n" + "> > * direct reclaim and reclaim/compaction depends on\n" + "> > * compaction being called after reclaim so call directly if\n" + "> > * necessary\n" + "> > */\n" + "> > page = __alloc_pages_direct_compact(gfp_mask, order,\n" + "> > zonelist, high_zoneidx,\n" + "> > nodemask,\n" + "> > alloc_flags, preferred_zone,\n" + "> > migratetype, &did_some_progress,\n" + "> > sync_migration);\n" "> >\n" "> > __GFP_NORETRY is used in a bunch of places and while the most\n" "> > of them are not high-order, some of them potentially are like in\n" "> > sound/core/memalloc.c. Using __GFP_NO_KSWAPD as the flag allows\n" - "> > these callers to continue using sync compaction. \302\240It could be argued\n" + "> > these callers to continue using sync compaction. It could be argued\n" "> \n" "> Okay. If I was biased first, I have opposed this comment because they\n" "> might think __GFP_NORETRY is very latency sensitive.\n" @@ -284,6 +284,13 @@ "+\tsync_migration = !(gfp_mask & __GFP_NO_KSWAPD);\n" " \n" " \t/* Try direct reclaim and then allocating */\n" - " \tpage = __alloc_pages_direct_reclaim(gfp_mask, order," + " \tpage = __alloc_pages_direct_reclaim(gfp_mask, order,\n" + "\n" + "--\n" + "To unsubscribe, send a message with 'unsubscribe linux-mm' in\n" + "the body to majordomo@kvack.org. For more info on Linux MM,\n" + "see: http://www.linux-mm.org/ .\n" + "Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/\n" + "Don't email: <a href=mailto:\"dont@kvack.org\"> email@kvack.org </a>" -b14e11e9c1400649081bef36aa13e5620b17be7d0d8cbd19b644149fc204c389 +23329ec6f39d9ed661621135a0846586d55fe3fa1326d4c50b606a67368be522
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.