From: Ben Myers <bpm@sgi.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 2/5] xfs: use per-filesystem I/O completion workqueues
Date: Thu, 10 Nov 2011 11:42:42 -0600 [thread overview]
Message-ID: <20111110174242.GZ20464@sgi.com> (raw)
In-Reply-To: <20111109075847.GA20604@infradead.org>
Hey Christoph,
On Wed, Nov 09, 2011 at 02:58:47AM -0500, Christoph Hellwig wrote:
> +STATIC int
> +xfs_init_mount_workqueues(
> + struct xfs_mount *mp)
> +{
> +#define XFS_WQ_NAME_LEN 512
> + char name[XFS_WQ_NAME_LEN];
> +
> + snprintf(name, XFS_WQ_NAME_LEN, "xfs-data/%s", mp->m_fsname);
> + mp->m_data_workqueue = alloc_workqueue(name, WQ_MEM_RECLAIM, 1);
> + if (!mp->m_data_workqueue)
> + goto out;
Looks to me like alloc_workqueue holds on to that name pointer in
wq->name... won't overwriting the name below be a problem?
> + snprintf(name, XFS_WQ_NAME_LEN, "xfs-conv/%s", mp->m_fsname);
> + mp->m_unwritten_workqueue = alloc_workqueue(name, WQ_MEM_RECLAIM, 1);
> + if (!mp->m_unwritten_workqueue)
> + goto out_destroy_data_iodone_queue;
-Ben
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-11-10 17:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-08 8:56 [PATCH 0/5] log all file size updates Christoph Hellwig
2011-11-08 8:56 ` [PATCH 1/5] fix: force shutdown handling in xfs_end_io Christoph Hellwig
2011-11-08 8:56 ` [PATCH 2/5] xfs: use per-filesystem I/O completion workqueues Christoph Hellwig
2011-11-08 23:11 ` Dave Chinner
2011-11-09 7:58 ` Christoph Hellwig
2011-11-10 17:42 ` Ben Myers [this message]
2011-11-14 10:34 ` Christoph Hellwig
2011-11-14 10:34 ` Christoph Hellwig
2011-11-14 18:13 ` Tejun Heo
2011-11-14 18:13 ` Tejun Heo
2011-11-08 8:56 ` [PATCH 3/5] xfs: do not require an ioend for new EOF calculation Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2011-11-15 20:14 [PATCH 0/5] for-3.2 queue Christoph Hellwig
2011-11-15 20:14 ` [PATCH 2/5] xfs: use per-filesystem I/O completion workqueues Christoph Hellwig
2011-11-16 19:01 ` Ben Myers
2011-11-17 7:40 ` Christoph Hellwig
2011-11-16 23:24 ` Dave Chinner
2011-11-17 7:25 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111110174242.GZ20464@sgi.com \
--to=bpm@sgi.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.