From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH] ARM: OMAP: Introduce local common.h files Date: Thu, 10 Nov 2011 13:50:09 -0800 Message-ID: <20111110215008.GX31337@atomide.com> References: <20111106135250.GC15294@n2100.arm.linux.org.uk> <20111108004550.GH31337@atomide.com> <20111110201719.GW31337@atomide.com> <20111110202356.GQ15294@n2100.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mho-02-ewr.mailhop.org ([204.13.248.72]:37438 "EHLO mho-02-ewr.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752620Ab1KJVuP (ORCPT ); Thu, 10 Nov 2011 16:50:15 -0500 Content-Disposition: inline In-Reply-To: <20111110202356.GQ15294@n2100.arm.linux.org.uk> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Russell King - ARM Linux Cc: linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-samsung-soc@vger.kernel.org * Russell King - ARM Linux [111110 11:49]: > On Thu, Nov 10, 2011 at 12:17:19PM -0800, Tony Lindgren wrote: > > As suggested by Russell King - ARM Linux , > > there's no need to keep local prototypes in non-local headers. > > > > Add mach-omap1/common.h and mach-omap2/common.h and move the > > local prototypes there from plat/common.h and mach/omap4-common.h. > > > > Signed-off-by: Tony Lindgren > > Great, looks fine, thanks. I suspect the chance of conflicts on this are > about the same as the chance of conflicts with the rest of the restart > series (in that, new platforms will need to be fixed for both these > changes.) > > So, I suggest that I add it to my series so I can fix the OMAP changes > there so stuff still builds - and then I can see about publishing a more > stable branch in a couple of weeks for new platforms to base on. OK, a stable branch is needed badly for this.. If possible please publish some minimal stable base branch as soon as you can as pretty much all omap patches need to be updated for this one. > If you agree, could you put it in the patch system please? Thanks. Sounds good to me, it there now as patch 7159/1. Regards, Tony From mboxrd@z Thu Jan 1 00:00:00 1970 From: tony@atomide.com (Tony Lindgren) Date: Thu, 10 Nov 2011 13:50:09 -0800 Subject: [PATCH] ARM: OMAP: Introduce local common.h files In-Reply-To: <20111110202356.GQ15294@n2100.arm.linux.org.uk> References: <20111106135250.GC15294@n2100.arm.linux.org.uk> <20111108004550.GH31337@atomide.com> <20111110201719.GW31337@atomide.com> <20111110202356.GQ15294@n2100.arm.linux.org.uk> Message-ID: <20111110215008.GX31337@atomide.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org * Russell King - ARM Linux [111110 11:49]: > On Thu, Nov 10, 2011 at 12:17:19PM -0800, Tony Lindgren wrote: > > As suggested by Russell King - ARM Linux , > > there's no need to keep local prototypes in non-local headers. > > > > Add mach-omap1/common.h and mach-omap2/common.h and move the > > local prototypes there from plat/common.h and mach/omap4-common.h. > > > > Signed-off-by: Tony Lindgren > > Great, looks fine, thanks. I suspect the chance of conflicts on this are > about the same as the chance of conflicts with the rest of the restart > series (in that, new platforms will need to be fixed for both these > changes.) > > So, I suggest that I add it to my series so I can fix the OMAP changes > there so stuff still builds - and then I can see about publishing a more > stable branch in a couple of weeks for new platforms to base on. OK, a stable branch is needed badly for this.. If possible please publish some minimal stable base branch as soon as you can as pretty much all omap patches need to be updated for this one. > If you agree, could you put it in the patch system please? Thanks. Sounds good to me, it there now as patch 7159/1. Regards, Tony