From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Barnes Subject: Re: [PATCH 1/7] drm: Zero initialize drm_mode_fb_cmd2 in legacy addfb ioctl handler Date: Fri, 11 Nov 2011 08:55:42 -0800 Message-ID: <20111111085542.4d069398@jbarnes-desktop> References: <1321027447-17921-1-git-send-email-ville.syrjala@linux.intel.com> <1321027447-17921-2-git-send-email-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0632910464==" Return-path: Received: from oproxy8-pub.bluehost.com (oproxy8-pub.bluehost.com [69.89.22.20]) by gabe.freedesktop.org (Postfix) with SMTP id B9D39A0E3D for ; Fri, 11 Nov 2011 08:55:24 -0800 (PST) In-Reply-To: <1321027447-17921-2-git-send-email-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: ville.syrjala@linux.intel.com Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0632910464== Content-Type: multipart/signed; micalg=PGP-SHA1; boundary="Sig_/U.2GODb2pTxzj7w4ATfCnjz"; protocol="application/pgp-signature" --Sig_/U.2GODb2pTxzj7w4ATfCnjz Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On Fri, 11 Nov 2011 18:04:01 +0200 ville.syrjala@linux.intel.com wrote: > From: Ville Syrj=E4l=E4 >=20 > Avoids having junk in offsets[] and pitches[] arrays. >=20 > Signed-off-by: Ville Syrj=E4l=E4 > --- > drivers/gpu/drm/drm_crtc.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) >=20 > diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c > index 39cccb4..7058ed3 100644 > --- a/drivers/gpu/drm/drm_crtc.c > +++ b/drivers/gpu/drm/drm_crtc.c > @@ -1967,7 +1967,7 @@ int drm_mode_addfb(struct drm_device *dev, > void *data, struct drm_file *file_priv) > { > struct drm_mode_fb_cmd *or =3D data; > - struct drm_mode_fb_cmd2 r; > + struct drm_mode_fb_cmd2 r =3D {}; > struct drm_mode_config *config =3D &dev->mode_config; > struct drm_framebuffer *fb; > int ret =3D 0; Yep, doesn't hurt... Acked-by: Jesse Barnes --=20 Jesse Barnes, Intel Open Source Technology Center --Sig_/U.2GODb2pTxzj7w4ATfCnjz Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iQIcBAEBAgAGBQJOvVOOAAoJEIEoDkX4Qk9hlygP/0J1wD/U1vhzBSd6SeWG7d8x MUSm7bpnZo8TIFFgC6L3I7rZDLGCuuYUrqxZYycCPx3tmrhpWOWXhs7XclNPFHJj yZRk0smSvYKx3h1VNNj6TYgG3hsD6QgH7DfzBE7UQfaC1GMHLcylM0phVA/S57kG cyUhrLBT/1KDaROJDOisNzpXwYUR4soepM/fem4Ue6i32m58fgMw89lia93L7MtP LJaUf/Q2fwlHt7NxhcJt6OAmjB5pz6nGVXQe4TuGmgvaFtvJNdRfSbCWnaMYUeqB QzU2/bR2j1zw3zdbdlQuQwzernCRDRA+fi+Vyahs0BxxH5tHdjzp4y4GBNV0VHsA XC6kGY1uolMNvHZDCj3n+tfrSq9ww6B78iM01NFunVwM2qtEFDbDnmsQzy0kxadm 9aJQJe2zTKt7xlypeLmpLFtEgI14KSgDeveApWu4ELorR9HfxD9KUY7LD9zP62vB 15GAhvNGxOfNCusYTLn2V0L6FJvNUeOZRyI6gxeq33EZy3ROnxzKOypznEjDDPb9 UrGX7dud9EqT6LBfJCDojnCZH9SyAQHA5Typl/+vbXFfO3+g9QLfI0LbFAfhw1JU shQ4T9BmNBGwVrukqqrWYpXKTnt9eSCZRI6nmeLEKMPxfbs9HnVjaNMUJqv4iz5V Esf3g9TPJY3G4PerxvTb =jwyD -----END PGP SIGNATURE----- --Sig_/U.2GODb2pTxzj7w4ATfCnjz-- --===============0632910464== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel --===============0632910464==--