From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Barnes Subject: Re: [PATCH 3/7] drm: plane: Clear plane.crtc and plane.fb after disable_plane() Date: Fri, 11 Nov 2011 08:56:19 -0800 Message-ID: <20111111085619.0cb1c23b@jbarnes-desktop> References: <1321027447-17921-1-git-send-email-ville.syrjala@linux.intel.com> <1321027447-17921-4-git-send-email-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0782068765==" Return-path: Received: from oproxy8-pub.bluehost.com (oproxy8-pub.bluehost.com [69.89.22.20]) by gabe.freedesktop.org (Postfix) with SMTP id 40711A0E7F for ; Fri, 11 Nov 2011 08:55:59 -0800 (PST) In-Reply-To: <1321027447-17921-4-git-send-email-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: ville.syrjala@linux.intel.com Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0782068765== Content-Type: multipart/signed; micalg=PGP-SHA1; boundary="Sig_/VOe22ZXCs9Vkr_/ND2EBUWN"; protocol="application/pgp-signature" --Sig_/VOe22ZXCs9Vkr_/ND2EBUWN Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On Fri, 11 Nov 2011 18:04:03 +0200 ville.syrjala@linux.intel.com wrote: > From: Ville Syrj=E4l=E4 >=20 > These are the only indication to user space that the plane was disabled. >=20 > Signed-off-by: Ville Syrj=E4l=E4 > --- > drivers/gpu/drm/drm_crtc.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) >=20 > diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c > index d3b884e..70f5747 100644 > --- a/drivers/gpu/drm/drm_crtc.c > +++ b/drivers/gpu/drm/drm_crtc.c > @@ -1677,6 +1677,8 @@ int drm_mode_setplane(struct drm_device *dev, void = *data, > /* No fb means shut it down */ > if (!plane_req->fb_id) { > plane->funcs->disable_plane(plane); > + plane->crtc =3D NULL; > + plane->fb =3D NULL; > goto out; > } > =20 A 0 return code should also indicate that the function succeeded, but this doesn't hurt. Acked-by: Jesse Barnes --=20 Jesse Barnes, Intel Open Source Technology Center --Sig_/VOe22ZXCs9Vkr_/ND2EBUWN Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iQIcBAEBAgAGBQJOvVOzAAoJEIEoDkX4Qk9hGnwP/361/1AcgU1CzfRpHhbAAL92 nVB2LLYc4Pbldackpthr6D65l1C6ED72V9/O5tAoyQrIfMG4fkD0glbAmvj4INZN 0XiFLFCD6kxhA7wizm1Q3lefu8IP+eljL5LpwGiQMldOjOf9aNb6XOQQWCFr+iY6 D+2fCj/GoAOS7fZjj/SLHPKWJ0pFqAxhldGTOCvnx3ojqjGdCSGu+LBABI9KpMaT ZebJKWH1rlyYpYi8/XR0jok7+RsTVkLJxjjxE6f9s/yUJ+NWL+D5zdq1Mwg4X9Tq zzN/KdexGixxIyZeQS5JhdCEByOwosunVTip5GqPF+xjxdW6CTsrxEQ3HPyCWOWg WdTBVmHwrU/bFOWUwaKlCPTPlMtqQm5GjbY5TzpzzM1al/i5wSK/g0ZEayqlXdEf eDwr4JHAgph7Imknh6mCidj8m+QJAhaxeEfLn8TgU9r0Jg3DlLtCDn3NSb6mOASo taOY/D8hlMEKQArsLjTkz6lCqO7LYkJlNI9Y2nSRNMSB9IWqVHuqtXpX4nqVZKnk vzYQRKEGBzLTB88xBXr1hoHHlpPVT53pPud2vEDbNmXjCAppKQLuMKXAcciP6B/q uDX09Ed8cHlfrZzDJ7Czk0Je6DwDbbgJ7deMKQ5zTAl2p5fqsgvRmtAlowvscV27 9EG0XGYWUWGlUoG2oCwr =Hl4I -----END PGP SIGNATURE----- --Sig_/VOe22ZXCs9Vkr_/ND2EBUWN-- --===============0782068765== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel --===============0782068765==--