From: Joerg Roedel <joerg.roedel@amd.com>
To: David Airlie <airlied@linux.ie>, David Woodhouse <dwmw2@infradead.org>
Cc: <linux-kernel@vger.kernel.org>, <iommu@lists.linux-foundation.org>
Subject: [PATCH] iommu/intel: Fix build failure with intel-gtt and !intel-iommu
Date: Fri, 11 Nov 2011 14:48:32 +0100 [thread overview]
Message-ID: <20111111134832.GI13213@amd.com> (raw)
Not sure if this is fixed already. I stumbled over it while
compile-testing merges in the IOMMU tree.
>From 7d8438f41b3cfbb1094030d7cf5d06da0fd16308 Mon Sep 17 00:00:00 2001
From: Joerg Roedel <joerg.roedel@amd.com>
Date: Fri, 11 Nov 2011 14:42:53 +0100
Subject: [PATCH] iommu/intel: Fix build failure with intel-gtt and !intel-iommu
With v3.2-rc1 the following build error occurs when Intel
IOMMU is off and Intel-GTT is on:
ERROR: "intel_iommu_gfx_mapped" [drivers/char/agp/intel-gtt.ko] undefined!
This patch fixes that.
Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
---
drivers/char/agp/intel-gtt.c | 2 +-
include/linux/intel-iommu.h | 6 ++++++
2 files changed, 7 insertions(+), 1 deletions(-)
diff --git a/drivers/char/agp/intel-gtt.c b/drivers/char/agp/intel-gtt.c
index 66cd0b8..bfe5133 100644
--- a/drivers/char/agp/intel-gtt.c
+++ b/drivers/char/agp/intel-gtt.c
@@ -22,6 +22,7 @@
#include <linux/pagemap.h>
#include <linux/agp_backend.h>
#include <linux/delay.h>
+#include <linux/intel-iommu.h>
#include <asm/smp.h>
#include "agp.h"
#include "intel-agp.h"
@@ -1186,7 +1187,6 @@ static void gen6_cleanup(void)
/* Certain Gen5 chipsets require require idling the GPU before
* unmapping anything from the GTT when VT-d is enabled.
*/
-extern int intel_iommu_gfx_mapped;
static inline int needs_idle_maps(void)
{
const unsigned short gpu_devid = intel_private.pcidev->device;
diff --git a/include/linux/intel-iommu.h b/include/linux/intel-iommu.h
index e6ca56d..651cc08 100644
--- a/include/linux/intel-iommu.h
+++ b/include/linux/intel-iommu.h
@@ -363,4 +363,10 @@ extern int qi_submit_sync(struct qi_desc *desc, struct intel_iommu *iommu);
extern int dmar_ir_support(void);
+#ifdef CONFIG_INTEL_IOMMU
+extern int intel_iommu_gfx_mapped;
+#else
+#define intel_iommu_gfx_mapped 1
+#endif /* CONFIG_INTEL_IOMMU */
+
#endif
--
1.7.5.4
--
AMD Operating System Research Center
Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632
next reply other threads:[~2011-11-11 13:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-11 13:48 Joerg Roedel [this message]
2011-11-11 13:52 ` [PATCH] iommu/intel: Fix build failure with intel-gtt and !intel-iommu David Woodhouse
2011-11-11 14:24 ` Joerg Roedel
2011-11-11 14:24 ` Joerg Roedel
2011-11-14 13:26 ` Joerg Roedel
2011-11-14 13:26 ` Joerg Roedel
2011-11-14 13:35 ` Dave Airlie
2011-11-14 14:29 ` Joerg Roedel
2011-11-14 14:29 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111111134832.GI13213@amd.com \
--to=joerg.roedel@amd.com \
--cc=airlied@linux.ie \
--cc=dwmw2@infradead.org \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.