All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [bisected][bug] commit e978aa7d7d57d04eb5f88 breaks suspend on laptop.
Date: Sat, 12 Nov 2011 03:41:12 +0000	[thread overview]
Message-ID: <201111120341.12473.arnd@arndb.de> (raw)

On Saturday, November 12, 2011, Rafael J. Wysocki wrote:
> If that's "acpi_idle", the appended patch should help (it works for
> me at least).

Hi Rafael,

I currently have limited email connectivity but I happened to bisect the
same bug and your patch fixes it for me. I am certainly on acpi_idle
with my thinkpad w500.

Sorry for breaking the email threading and dropping people from Cc.

> From: Rafael J. Wysocki <rjw@sisk.pl>
> Subject: ACPI / cpuidle: Remove acpi_idle_suspend (to fix suspend regression)
> After commit e978aa7d7d57d04eb5f88a7507c4fb98577def77 (cpuidle: Move
> dev->last_residency update to driver enter routine; remove
> dev->last_state) setting acpi_idle_suspend to 1 by
> acpi_processor_suspend() causes the ACPI cpuidle routines to return
> error codes continuously, which in turn causes cpuidle to lock up
> (hard).  However, acpi_idle_suspend doesn't appear to be useful for
> any purpose (it's racy and doesn't really provide any real
> protection), so it can be removed, which makes the problem go away.
> 
> Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>

Tested-by: Arnd Bergmann <arnd@arndb.de>

	Arnd

             reply	other threads:[~2011-11-12  3:41 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-12  3:41 Arnd Bergmann [this message]
2011-11-12 22:25 ` [bisected][bug] commit e978aa7d7d57d04eb5f88 breaks suspend on laptop Rafael J. Wysocki
2011-11-12 23:49   ` Linus Torvalds
2011-11-13  0:18     ` Rafael J. Wysocki
  -- strict thread matches above, loose matches on Subject: below --
2011-11-11 16:01 Tomas M.
2011-11-11 20:46 ` Tomas M.
2011-11-11 21:26   ` Rafael J. Wysocki
2011-11-11 21:34     ` Tomas M.
2011-11-12  0:41       ` Rafael J. Wysocki
2011-11-12  1:50         ` Rafael J. Wysocki
2011-11-12 12:45           ` Ferenc Wagner
2011-11-12 22:14             ` Rafael J. Wysocki
2011-11-12 13:21           ` Tomas M.
2011-11-12 22:14             ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201111120341.12473.arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rjw@sisk.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.