Re: [PATCH V2 8/8] MIPS: BMIPS: Add SMP support code for BMIPS43xx/BMIPS5000

[Florian Fainelli <ffainelli@freebox.fr>]

Hello Kevin,

Le vendredi 11 novembre 2011 07:30:31, Kevin Cernekee a écrit :
> Initial commit of BMIPS SMP support code.  Smoke-tested on a variety of
> BMIPS4350, BMIPS4380, and BMIPS5000 platforms.
> 
> Signed-off-by: Kevin Cernekee <cernekee@gmail.com>
> ---
> 
> V2:
> 
> Move XKS01 option into this patch.
> 
> Remove dependency on local_flush_tlb_all_mm(), per the discussion
> earlier this week.
> 
> Allow platform-configurable variables to be accessed in !CONFIG_SMP
> mode, so the platform code does not need unnecessary #ifdefs.
> 
> Remove the code that clears the FPU registers.
> 
> Fix the jump to the NMI vector.
> 
> Add bmips_cpu_offset.

I have two questions regarding this patchset:

- considering that BMIPS4350 has a shared TLB, is it still working fine? I must 
say that I have not yet tested on e.g: BCM6358

- there a couple of places in the code where we have:

#if defined (CONFIG_BMIPS_4350) || defined (CONFIG_BMIPS_4380)
 ... do something
#elif defined(CONFIG_BMIPS_4380)

can we turn this into a #if BMIPS43xx case .. #endif  #if BMIPS5000 ... #endif 
to allow a single image supporting both BMIPS43xx and BMIPS5000?

By the time we are initializing the CPUs for SMP, we should be able to use 
runtime checks on the BMIPS CPU variant.

Thanks.
-- 
Florian