All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steffen Klassert <steffen.klassert@secunet.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 2/4] ipv4: Update pmtu informations on inetpeer only for output routes
Date: Mon, 14 Nov 2011 11:12:44 +0100	[thread overview]
Message-ID: <20111114101244.GB20943@secunet.com> (raw)
In-Reply-To: <20111108.143630.106539981030509701.davem@davemloft.net>

On Tue, Nov 08, 2011 at 02:36:30PM -0500, David Miller wrote:
> 
> What I think you can do to solve this problem is explicitly use
> dst->ops->default_mtu() in ip_forward() instead of dst_mtu().
> 

Unfortunately, that's not sufficient. We need to do an input route
check in ip_skb_dst_mtu() at least to get plain ipv4 to work,
IPsec is still broken then. So I assume most (all?) callers of
dst_mtu() don't want to get the cached PMTU for input routes on ipv4.

So for the moment I'm thinking about adding an ip_dst_mtu()
function that returns dst->ops->default_mtu() for input routes
and dst_mtu() for output routes. Then we could convert the
dst_mtu() users in net/ipv4/ over to this one.

  parent reply	other threads:[~2011-11-14 10:12 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-11 11:08 [PATCH net 0/4] ipv4: various pmtu discovery fixes Steffen Klassert
2011-10-11 11:09 ` [PATCH 1/4] ipv4: Fix pmtu propagating Steffen Klassert
2011-10-12 21:02   ` David Miller
2011-10-13 10:09     ` Steffen Klassert
2011-10-13 17:58       ` David Miller
2011-10-14  5:54         ` Steffen Klassert
2011-10-17 12:18           ` Steffen Klassert
2011-10-19  9:07             ` Gao feng
2011-10-19 19:32               ` David Miller
2011-11-08 19:19                 ` David Miller
2011-11-08 19:33                   ` David Miller
2011-11-09 12:08                     ` Steffen Klassert
2011-11-21  7:56                       ` Steffen Klassert
2011-12-01 18:40                         ` David Miller
2011-10-11 11:10 ` [PATCH 2/4] ipv4: Update pmtu informations on inetpeer only for output routes Steffen Klassert
2011-10-12 21:08   ` David Miller
2011-10-14  6:34     ` Steffen Klassert
2011-11-08 19:36     ` David Miller
2011-11-09 12:11       ` Steffen Klassert
2011-11-14 10:12       ` Steffen Klassert [this message]
2011-11-14 19:33         ` David Miller
2011-11-15 10:00           ` Steffen Klassert
2011-11-22 13:20           ` Steffen Klassert
2011-10-11 11:11 ` [PATCH 3/4] ipv4: Fix inetpeer expiration handling Steffen Klassert
2011-10-20  6:24   ` Gao feng
2011-11-08 19:38     ` David Miller
2011-11-09 12:47     ` Steffen Klassert
2011-10-11 11:12 ` [PATCH 4/4] ipv4: Fix inetpeer expire time information Steffen Klassert
2011-10-11 19:54 ` [PATCH net 0/4] ipv4: various pmtu discovery fixes David Miller
2011-11-08 19:41   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111114101244.GB20943@secunet.com \
    --to=steffen.klassert@secunet.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.