From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Date: Mon, 14 Nov 2011 18:23:04 +0100 Subject: [U-Boot] [PATCH 1/4] tegra2: Avoid warnings if CONFIG_SYS_TEXT_BASE is redefined. In-Reply-To: References: <1321276896-28963-1-git-send-email-thierry.reding@avionic-design.de> <74CDBE0F657A3D45AFBB94109FB122FF1740805AA7@HQMAIL01.nvidia.com> Message-ID: <20111114172304.GA349@avionic-0098.adnet.avionic-design.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de * Simon Glass wrote: > Hi Stephen, > > On Mon, Nov 14, 2011 at 9:09 AM, Stephen Warren wrote: > > Thierry Reding wrote at Monday, November 14, 2011 6:22 AM: > >> If a board configuration file redefines CONFIG_SYS_TEXT_BASE, the U-Boot > >> build system will usually define it explicitly on the compiler command- > >> line, which will cause the define in tegra2-common.h to emit a > >> redefinition warning. > >> > >> To allow boards to redefine CONFIG_SYS_TEXT_BASE, tegra2-common.h now > >> only defines CONFIG_SYS_TEXT_BASE when it isn't already defined by the > >> board configuration or the command-line respectively. > > > > Instead of doing this, wouldn't it make sense to just switch all Tegra > > boards to TEXT_BASE=00108000 to match NVIDIA's flashing tool's assumptions? > > That way, no board would need to override TEXT_BASE at all. > > > > These assumptions are true for all boards in the standard flashing tool > > builds; it's just that non-standard builds exist for some boards (those > > that happened to be upstreamed to U-Boot first) that allow use of 00e08000 > > instead. > > > > Tom, Simon, what are your thoughts here? > > I was going to say the same thing. Okay, I can integrate that into the second version. Or would you prefer a separate patch? Thierry -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 198 bytes Desc: not available Url : http://lists.denx.de/pipermail/u-boot/attachments/20111114/8084b31f/attachment.pgp