From: Dave Jones <davej@redhat.com>
To: Johannes Weiner <jweiner@redhat.com>
Cc: Andrea Arcangeli <aarcange@redhat.com>,
Mel Gorman <mgorman@suse.de>, Jan Kara <jack@suse.cz>,
Andy Isaacson <adi@hexapodia.org>,
linux-kernel@vger.kernel.org, linux-mm@vger.kernel.org,
kernel-team@fedoraproject.org
Subject: Re: long sleep_on_page delays writing to slow storage
Date: Mon, 14 Nov 2011 13:47:17 -0500 [thread overview]
Message-ID: <20111114184717.GA7006@redhat.com> (raw)
In-Reply-To: <20111110093442.GG3153@redhat.com>
On Thu, Nov 10, 2011 at 10:34:42AM +0100, Johannes Weiner wrote:
> > I wonder if a change like this would be enough?
> >
> > sync_migration = !(gfp_mask & __GFP_NO_KSWAPD);
> >
> > But even if hidden in a new function, the main downside overall is the
> > fact we'll pass one more var through the stack of fast paths.
> >
> > Johannes I recall you reported this too and Mel suggested the above
> > change, did it help in the end?
>
> Yes, it completely fixed the latency problem.
>
> That said, I haven't looked at the impact on the THP success rate, but
> a regression there is probably less severe than half-minute-stalls in
> interactive applications.
FWIW, we've had a few reports from Fedora users since we moved to 3.x kernels
about similar problems, so whatever the fix is for this should probably
go to stable too.
I could push an update for Fedora users to test the change above if
that would be helpful ?
Dave
next prev parent reply other threads:[~2011-11-14 18:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-07 4:59 long sleep_on_page delays writing to slow storage Andy Isaacson
2011-11-09 17:00 ` Jan Kara
2011-11-09 17:52 ` Mel Gorman
2011-11-09 18:06 ` Andrea Arcangeli
2011-11-10 0:53 ` Mel Gorman
2011-11-10 1:54 ` Andrea Arcangeli
2011-11-10 9:34 ` Johannes Weiner
2011-11-14 18:47 ` Dave Jones [this message]
2011-11-15 10:13 ` Mel Gorman
2011-11-17 19:47 ` Dave Jones
2011-11-17 22:53 ` Andrea Arcangeli
2011-11-18 11:11 ` Mel Gorman
2011-11-18 12:19 ` Josh Boyer
2011-11-21 9:18 ` Johannes Weiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111114184717.GA7006@redhat.com \
--to=davej@redhat.com \
--cc=aarcange@redhat.com \
--cc=adi@hexapodia.org \
--cc=jack@suse.cz \
--cc=jweiner@redhat.com \
--cc=kernel-team@fedoraproject.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@vger.kernel.org \
--cc=mgorman@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.