Re: [lm-sensors] [PATCH] Drivers: hwmon: it87: Add support for ITE

["Gustavo De Nardin (spuk)" <gustavodn@gmail.com>]

> On Fri, 2011-11-04 at 00:44 -0400, Frank T. Lofaro Jr. wrote:
> > This patch allows the ITE 8728 chip to be detected and used.
> > The chip appears to be compatible with the 8721.
> > 
> 
> Can anyone confirm that those chips are actually compatible ?

Unlike forcing the other chips' ids, with force_id=0x8721 PWM control seems
to work reasonably, with pwm1_enable=1, pwm1=0 yields around 1132 RPM on the
CPU fan, and pwm1=255 yields around 3260 RPM.  Should pwm1=0 actually stop
the fan?  I get what (empirically) seem to be consistent logarithmic
increase in RPM when increasing pwm1 value, anyway.

But the sensors values read with 'it87 force_id=0x8721' don't seem ok, I get
this (first 'it87 force_id=0x8721', then 'asus_atk0110 new_if=1', which
seems to provide good readings):

it8721-isa-0290
Adapter: ISA adapter
in0:          +0.95 V  (min =  +2.78 V, max =  +1.14 V)  ALARM
in1:          +1.50 V  (min =  +0.00 V, max =  +3.01 V)
in2:          +1.88 V  (min =  +2.66 V, max =  +2.27 V)  ALARM
in3:          +2.05 V  (min =  +2.68 V, max =  +0.67 V)  ALARM
in4:          +2.03 V  (min =  +3.04 V, max =  +1.42 V)  ALARM
in5:          +3.05 V  (min =  +3.04 V, max =  +3.01 V)  ALARM
in6:          +2.05 V  (min =  +2.77 V, max =  +1.87 V)  ALARM
3VSB:         +6.07 V  (min =  +1.10 V, max =  +4.56 V)  ALARM
Vbat:         +3.34 V
fan1:        3292 RPM  (min =   10 RPM)
fan2:           0 RPM  (min =   10 RPM)  ALARM
fan3:           0 RPM  (min =   13 RPM)  ALARM
temp1:        +33.0°C  (low  = -65.0°C, high = -10.0°C)  sensor = thermistor
temp2:        +40.0°C  (low  = -19.0°C, high = +127.0°C)  sensor =
thermistor
temp3:       -128.0°C  (low  = +119.0°C, high =  -2.0°C)  sensor = disabled
intrusion0:  OK

atk0110-acpi-0
Adapter: ACPI interface
Vcore Voltage:      +0.95 V  (min =  +0.80 V, max =  +1.60 V)
+3.3V Voltage:      +3.34 V  (min =  +2.97 V, max =  +3.63 V)
+5V Voltage:        +5.13 V  (min =  +4.50 V, max =  +5.50 V)
+12V Voltage:      +12.11 V  (min = +10.20 V, max = +13.80 V)
CPU Fan Speed:     3276 RPM  (min =  600 RPM)
Chassis Fan Speed:    0 RPM  (min =  600 RPM)
CPU Temperature:    +33.0°C  (high = +60.0°C, crit = +95.0°C)
MB Temperature:     +40.0°C  (high = +45.0°C, crit = +75.0°C)


This is on an Asus M5A78L-M/USB3 mainboard.

t'


> 
> Thanks,
> Guenter
> 
> Signed-off-by: Frank T. Lofaro Jr. <ftlofaro at yahoo.com>
> > ---
> >  drivers/hwmon/it87.c |    3 +++
> >  1 files changed, 3 insertions(+), 0 deletions(-)
> > 
> > diff --git a/drivers/hwmon/it87.c b/drivers/hwmon/it87.c
> > index d912649..0b21d18 100644
> > --- a/drivers/hwmon/it87.c
> > +++ b/drivers/hwmon/it87.c
> > @@ -17,6 +17,7 @@
> >   *            IT8720F  Super I/O chip w/LPC interface
> >   *            IT8721F  Super I/O chip w/LPC interface
> >   *            IT8726F  Super I/O chip w/LPC interface
> > + *            IT8728F  Super I/O chip w/LPC interface
> >   *            IT8758E  Super I/O chip w/LPC interface
> >   *            Sis950   A clone of the IT8705F
> >   *
> > @@ -135,6 +136,7 @@ static inline void superio_exit(void)
> >  #define IT8720F_DEVID 0x8720
> >  #define IT8721F_DEVID 0x8721
> >  #define IT8726F_DEVID 0x8726
> > +#define IT8728F_DEVID 0x8728
> >  #define IT87_ACT_REG  0x30
> >  #define IT87_BASE_REG 0x60
> >  
> > @@ -1603,6 +1605,7 @@ static int __init it87_find(unsigned short
> > *address,
> >                 sio_data->type = it8720;
> >                 break;
> >         case IT8721F_DEVID:
> > +       case IT8728F_DEVID:
> >                 sio_data->type = it8721;
> >                 break;
> >         case 0xffff:    /* No device at all */
> > -- 
> > 1.7.7.2

-- 
::question = (bool) _2b||!_2b;

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors