All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
	Vinod Koul <vinod.koul@intel.com>,
	Nicolas Ferre <nicolas.ferre@atmel.com>,
	Dan Williams <dan.j.williams@intel.com>
Subject: Re: linux-next: build failure after merge of the pm tree (and warning)
Date: Mon, 14 Nov 2011 15:39:57 -0800	[thread overview]
Message-ID: <20111114233957.GF30922@google.com> (raw)
In-Reply-To: <Pine.LNX.4.64.1111150032170.32143@axis700.grange>

Hello, Guennadi.

On Tue, Nov 15, 2011 at 12:33:29AM +0100, Guennadi Liakhovetski wrote:
> No, this isn't a correct fix.

I've been looking at the code and am scratching my head about what
happens after timeout.  If test timed out (tmo == 0), it prints out
error message and continues to the next iteration of the test loop,
which will reinitialize the on-stack completion.  This essentially
makes the previous test run's callback_param pointer dangling.  The
completion needs to be either detached from the callback or waited
upon even if it timed out.  Am I missing something?

Thanks.

-- 
tejun

  reply	other threads:[~2011-11-14 23:40 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-14  2:17 linux-next: build failure after merge of the pm tree (and warning) Stephen Rothwell
2011-11-14 23:14 ` Rafael J. Wysocki
2011-11-14 23:17   ` Tejun Heo
2011-11-14 23:24     ` Rafael J. Wysocki
2011-11-14 23:33   ` Guennadi Liakhovetski
2011-11-14 23:39     ` Tejun Heo [this message]
2011-11-15  2:52       ` Williams, Dan J
2011-11-15 20:52     ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111114233957.GF30922@google.com \
    --to=tj@kernel.org \
    --cc=dan.j.williams@intel.com \
    --cc=g.liakhovetski@gmx.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=nicolas.ferre@atmel.com \
    --cc=rjw@sisk.pl \
    --cc=sfr@canb.auug.org.au \
    --cc=vinod.koul@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.