From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guenter Roeck Date: Tue, 15 Nov 2011 03:39:26 +0000 Subject: Re: [lm-sensors] [PATCH] hwmon: (pmbus) Fix two issues Message-Id: <20111115033926.GA29299@ericsson.com> List-Id: References: <1321249266-17071-1-git-send-email-Yuantian.Tang@freescale.com> In-Reply-To: <1321249266-17071-1-git-send-email-Yuantian.Tang@freescale.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: lm-sensors@vger.kernel.org On Mon, Nov 14, 2011 at 09:58:03PM -0500, Tang Yuantian-B29983 wrote: > > > > -----Original Message----- > > From: Guenter Roeck [mailto:guenter.roeck@ericsson.com] > > Hmm ... looking into the code, I2C_FUNC_SMBUS_READ_BLOCK_DATA is missing > > from I2C_FUNC_SMBUS_EMUL. > > Now that is interesting. > > > > If you change mpc_functionality() to > > return I2C_FUNC_I2C | I2C_FUNC_SMBUS_EMUL | > > I2C_FUNC_SMBUS_READ_BLOCK_DATA; I bet your problem will disappear. > > > > Jean, any idea why I2C_FUNC_SMBUS_EMUL doesn't include > > I2C_FUNC_SMBUS_READ_BLOCK_DATA ? > > > [Yuantian:] unfortunately no, Even I add I2C_FUNC_SMBUS_READ_BLOCK_DATA support, > The return value is not correct. > I am not sure I understand what you mean with "not correct". Can you provide the output of the i2cdump command ? Command should be something like "i2cdump s 0xe4" with a recent version of i2cdump. Thanks, Guenter _______________________________________________ lm-sensors mailing list lm-sensors@lm-sensors.org http://lists.lm-sensors.org/mailman/listinfo/lm-sensors