From: Stephen Hemminger <shemminger@vyatta.com>
To: David Decotigny <david.decotigny@google.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Ian Campbell <ian.campbell@citrix.com>,
Eric Dumazet <eric.dumazet@gmail.com>,
Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
Ben Hutchings <bhutchings@solarflare.com>,
Jiri Pirko <jpirko@redhat.com>, Joe Perches <joe@perches.com>,
Szymon Janc <szymon@janc.net.pl>,
Richard Jones <rick.jones2@hp.com>,
Ayaz Abdulla <AAbdulla@nvidia.com>
Subject: Re: [PATCH net-next v4 4/8] forcedeth: expose module parameters in /sys/module
Date: Tue, 15 Nov 2011 14:32:31 -0800 [thread overview]
Message-ID: <20111115143231.454f612a@s6510.linuxnetplumber.net> (raw)
In-Reply-To: <558f3ff3d373b1cdcbebebe842816b3c91438728.1321384662.git.david.decotigny@google.com>
On Tue, 15 Nov 2011 11:25:37 -0800
David Decotigny <david.decotigny@google.com> wrote:
> +module_param(optimization_mode, int, S_IRUGO);
> MODULE_PARM_DESC(optimization_mode, "In throughput mode (0), every tx & rx packet will generate an interrupt. In CPU mode (1), interrupts are controlled by a timer. In dynamic mode (2), the mode toggles between throughput and CPU mode based on network load.");
Probably the original developer (or marketing data sheet), thought this was some
unique feature of the hardware. But most devices have this already.
This driver should just implement proper control irq coalescing control via ethtool
and get rid of the silly module parameter.
next prev parent reply other threads:[~2011-11-15 22:32 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-15 19:25 [PATCH net-next v4 0/8] forcedeth: stats & debug enhancements David Decotigny
2011-11-15 19:25 ` [PATCH net-next v4 1/8] forcedeth: fix stats on hardware without extended stats support David Decotigny
2011-11-15 19:25 ` [PATCH net-next v4 2/8] forcedeth: Add messages to indicate using MSI or MSI-X David Decotigny
2011-11-15 19:32 ` Joe Perches
[not found] ` <cover.1321386214.git.david.decotigny@google.com>
2011-11-15 19:51 ` David Decotigny
2011-11-15 19:25 ` [PATCH net-next v4 3/8] forcedeth: allow to silence "TX timeout" debug messages David Decotigny
2011-11-15 22:27 ` Stephen Hemminger
2011-11-15 19:25 ` [PATCH net-next v4 4/8] forcedeth: expose module parameters in /sys/module David Decotigny
2011-11-15 22:32 ` Stephen Hemminger [this message]
2011-11-15 22:33 ` Stephen Hemminger
2011-11-15 19:25 ` [PATCH net-next v4 5/8] forcedeth: implement ndo_get_stats64() API David Decotigny
2011-11-15 22:01 ` David Decotigny
2011-11-15 19:25 ` [PATCH net-next v4 6/8] forcedeth: account for dropped RX frames David Decotigny
2011-11-15 22:21 ` Stephen Hemminger
2011-11-15 22:35 ` David Decotigny
2011-11-15 19:25 ` [PATCH net-next v4 7/8] forcedeth: new ethtool stat counter for TX timeouts David Decotigny
2011-11-15 19:25 ` [PATCH net-next v4 8/8] forcedeth: stats updated with a deferrable timer David Decotigny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111115143231.454f612a@s6510.linuxnetplumber.net \
--to=shemminger@vyatta.com \
--cc=AAbdulla@nvidia.com \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=david.decotigny@google.com \
--cc=eric.dumazet@gmail.com \
--cc=ian.campbell@citrix.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=joe@perches.com \
--cc=jpirko@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rick.jones2@hp.com \
--cc=szymon@janc.net.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.