Re: [PATCH 2/2] ACPICA: support Generic Address Structure bit_offset in acpi_read/write

[Thomas Renninger <trenn@suse.de>]

On Tuesday, November 15, 2011 04:13:15 PM Bjorn Helgaas wrote:
> On Fri, Nov 11, 2011 at 4:05 PM, Bjorn Helgaas <bhelgaas@google.com> wrote:
> > acpi_read(), acpi_write(), acpi_hw_read(), and acpi_hw_write() currently
> > ignore the GAS bit_offset field (but they do warn if it is non-zero).
> >
> > APEI tables are starting to use non-zero bit_offsets.  APEI uses
> > special-purpose apei_exec_read_register() and apei_exec_write_register()
> > interfaces that apply the bit_offset.
> >
> > This patch adds bit_offset support to the generic interfaces, which is
> > one small step toward using them instead of the special-purpose APEI ones.
> 
> Eww, brown paper bag time.  Just pretend you never saw this lame
> implementation attempt.
> 
> I do think we need to make acpi_read() smart enough to extract a bit
> field, but this try doesn't work.

As a first step it would be great if Ying's and Myron's patches which
afaik conflict get serialized and pushed into an "acpi branch".
What the status there?

I'd like to add access width support to the APEI parts on top then.

Thanks,

   Thomas