From: Andrea Arcangeli <aarcange@redhat.com>
To: Shaohua Li <shaohua.li@intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-mm <linux-mm@kvack.org>
Subject: Re: [patch v2 3/4]thp: add tlb_remove_pmd_tlb_entry
Date: Tue, 15 Nov 2011 19:17:28 +0100 [thread overview]
Message-ID: <20111115181728.GJ4414@redhat.com> (raw)
In-Reply-To: <1321340658.22361.296.camel@sli10-conroe>
On Tue, Nov 15, 2011 at 03:04:18PM +0800, Shaohua Li wrote:
> We have tlb_remove_tlb_entry to indicate a pte tlb flush entry should be
> flushed, but not a corresponding API for pmd entry. This isn't a problem so far
> because THP is only for x86 currently and tlb_flush() under x86 will flush
> entire TLB. But this is confusion and could be missed if thp is ported to
> other arch.
> Also converted tlb->need_flush = 1 to a VM_BUG_ON(!tlb->need_flush) in
> __tlb_remove_page() as suggested by Andrea Arcangeli. __tlb_remove_page()
> is supposed to be called after tlb_remove_xxx_tlb_entry() and we can catch
> any misuse.
>
> Signed-off-by: Shaohua Li <shaohua.li@intel.com>
Reviewed-by: Andrea Arcangeli <aarcange@redhat.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-11-15 18:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-15 7:04 [patch v2 3/4]thp: add tlb_remove_pmd_tlb_entry Shaohua Li
2011-11-15 18:17 ` Andrea Arcangeli [this message]
2011-11-22 23:07 ` Andrew Morton
2011-11-23 3:29 ` Shaohua Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111115181728.GJ4414@redhat.com \
--to=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-mm@kvack.org \
--cc=shaohua.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.