From: Greg KH <greg@kroah.com>
To: Arjan van de Ven <arjan@infradead.org>
Cc: gregkh@suse.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] tty: make several fops functions non-static so that the pty code can use them
Date: Tue, 15 Nov 2011 12:21:47 -0800 [thread overview]
Message-ID: <20111115202147.GA25654@kroah.com> (raw)
In-Reply-To: <20111030094038.7046d529@infradead.org>
On Sun, Oct 30, 2011 at 09:40:38AM -0700, Arjan van de Ven wrote:
> From: Arjan van de Ven <arjan@linux.intel.com>
>
> The pty code currently does a partial function-pointer copy to fill its
> struct file_operations; this patch makes the functions it copies non-static
> in preparation of switching the pty code over to using proper prototypes.
>
> Signed-off-by: Arjan van de Ven <arjan@linux.intel.com>
With this patch, I get the following build error:
drivers/tty/tty_io.c:2712:13: error: static declaration of ‘tty_compat_ioctl’ follows non-static declaration
include/linux/tty.h:492:13: note: previous declaration of ‘tty_compat_ioctl’ was here
drivers/tty/tty_io.c:2712:13: warning: ‘tty_compat_ioctl’ defined but not used
Please fix up the series and resend them, in a format that I can apply
them in, without having to edit the body of the patch by hand.
thanks,
greg k-h
prev parent reply other threads:[~2011-11-15 20:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-30 16:40 [PATCH 1/3] tty: make several fops functions non-static so that the pty code can use them Arjan van de Ven
2011-10-30 16:41 ` [PATCH 2/3] tty: make the ptmx_fops initialized at compile time Arjan van de Ven
2011-10-30 16:42 ` [PATCH 3/3] tty: remove the (now) unused tty_default_fops() function Arjan van de Ven
2011-11-15 20:18 ` [PATCH 1/3] tty: make several fops functions non-static so that the pty code can use them Greg KH
2011-11-15 20:21 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111115202147.GA25654@kroah.com \
--to=greg@kroah.com \
--cc=arjan@infradead.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.