All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: David Howells <dhowells@redhat.com>
Cc: torvalds@linux-foundation.org, akpm@linux-foundation.org,
	linux-security-module@vger.kernel.org, keyrings@linux-nfs.org,
	linux-kernel@vger.kernel.org, Jeff Layton <jlayton@redhat.com>,
	Neil Horman <nhorman@redhat.com>,
	Steve Dickson <steved@redhat.com>,
	James Morris <jmorris@namei.org>
Subject: Re: [PATCH] KEYS: Fix a NULL pointer deref in the user-defined key type
Date: Tue, 15 Nov 2011 14:54:08 -0800	[thread overview]
Message-ID: <20111115225408.GA31763@kroah.com> (raw)
In-Reply-To: <20111115220945.18768.20275.stgit@warthog.procyon.org.uk>

On Tue, Nov 15, 2011 at 10:09:45PM +0000, David Howells wrote:
> Fix a NULL pointer deref in the user-defined key type whereby updating a
> negative key into a fully instantiated key will cause an oops to occur when the
> code attempts to free the non-existent old payload.
> 
> This results in an oops that looks something like the following:
> 
> BUG: unable to handle kernel NULL pointer dereference at 0000000000000008
> IP: [<ffffffff81085fa1>] __call_rcu+0x11/0x13e
> PGD 3391d067 PUD 3894a067 PMD 0
> Oops: 0002 [#1] SMP
> CPU 1
> Modules linked in:
> 
> Pid: 4354, comm: keyctl Not tainted 3.1.0-fsdevel+ #1140                  /DG965RY

Ah, so this patch should also go into the 3.1-stable tree?  Any older
ones as welL?

thanks,

greg k-h

      reply	other threads:[~2011-11-15 22:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-15 22:09 [PATCH] KEYS: Fix a NULL pointer deref in the user-defined key type David Howells
2011-11-15 22:54 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111115225408.GA31763@kroah.com \
    --to=greg@kroah.com \
    --cc=akpm@linux-foundation.org \
    --cc=dhowells@redhat.com \
    --cc=jlayton@redhat.com \
    --cc=jmorris@namei.org \
    --cc=keyrings@linux-nfs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=nhorman@redhat.com \
    --cc=steved@redhat.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.