From: Marek Vasut <marek.vasut@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 02/19] usbdev.c: Fix GCC 4.6 build warnings
Date: Wed, 16 Nov 2011 03:26:46 +0100 [thread overview]
Message-ID: <201111160326.46270.marek.vasut@gmail.com> (raw)
In-Reply-To: <201111151801.16723.vapier@gentoo.org>
> On Tuesday 15 November 2011 13:01:52 Stefan Roese wrote:
> > --- a/arch/powerpc/cpu/ppc4xx/usbdev.c
> > +++ b/arch/powerpc/cpu/ppc4xx/usbdev.c
> >
> > - int temp, temp1;
> > ...
> >
> > /*copy packet */
> > setup_packet_pt[0] = *(unsigned int *)USB2D0_FIFO_0;
> > setup_packet_pt[1] = *(unsigned int *)USB2D0_FIFO_0;
> >
> > - temp = *(unsigned int *)USB2D0_FIFO_0;
> > - temp1 = *(unsigned int *)USB2D0_FIFO_0;
>
> this seems to be treading into possible ugly volatile area ... perhaps best
> if this was acked/tested by someone with actual hardware first ...
> -mike
My words definitelly ... maybe replace with in_be32() ? It seems very
suspicious, as if there was a reason for this access. Like you need to do more
accesses to the fifo to clean up some trailing crud.
M
next prev parent reply other threads:[~2011-11-16 2:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-15 18:01 [U-Boot] [PATCH 02/19] usbdev.c: Fix GCC 4.6 build warnings Stefan Roese
2011-11-15 23:01 ` Mike Frysinger
2011-11-16 2:26 ` Marek Vasut [this message]
2011-12-09 9:31 ` Wolfgang Denk
2011-12-09 9:44 ` Stefan Roese
2011-12-09 11:18 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201111160326.46270.marek.vasut@gmail.com \
--to=marek.vasut@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.