From: Karel Zak <kzak@redhat.com>
To: Bernhard Voelker <mail@bernhard-voelker.de>
Cc: util-linux@vger.kernel.org
Subject: Re: [PATCH 10/15] prlimit: refactor code: separate modify and show clearly
Date: Wed, 16 Nov 2011 13:51:47 +0100 [thread overview]
Message-ID: <20111116125147.GH7916@nb.net.home> (raw)
In-Reply-To: <4EC07375.20005@bernhard-voelker.de>
On Mon, Nov 14, 2011 at 02:48:37AM +0100, Bernhard Voelker wrote:
> struct prlimit {
> struct rlimit rlim;
> - int found;
> struct prlimit_desc *desc;
> int modify;
> + int show;
> };
I think that 'modify == 0' means 'show'. It's strange to add two
variables to differentiate between two states.
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
next prev parent reply other threads:[~2011-11-16 12:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-14 1:48 [PATCH 10/15] prlimit: refactor code: separate modify and show clearly Bernhard Voelker
2011-11-14 10:54 ` [PATCH 10/15] prlimit: refactor code: separate modify and showclearly Davidlohr Bueso
2011-11-14 9:08 ` Voelker, Bernhard
2011-11-16 12:51 ` Karel Zak [this message]
2011-11-16 12:59 ` [PATCH 10/15] prlimit: refactor code: separate modify and show clearly Voelker, Bernhard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111116125147.GH7916@nb.net.home \
--to=kzak@redhat.com \
--cc=mail@bernhard-voelker.de \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.