From mboxrd@z Thu Jan  1 00:00:00 1970
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Subject: Re: [PATCH 11/14] drm/radeon/kms: enable the ttm dma pool if swiotlb
	is on V3
Date: Wed, 16 Nov 2011 10:46:57 -0500
Message-ID: <20111116154657.GA3952@phenom.dumpdata.com>
References: <1321051669-16675-1-git-send-email-j.glisse@gmail.com>
	<1321051669-16675-12-git-send-email-j.glisse@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org>
Received: from rcsinet15.oracle.com (rcsinet15.oracle.com [148.87.113.117])
	by gabe.freedesktop.org (Postfix) with ESMTP id 7982D9E7E8
	for <dri-devel@lists.freedesktop.org>;
	Wed, 16 Nov 2011 07:47:08 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <1321051669-16675-12-git-send-email-j.glisse@gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
To: j.glisse@gmail.com
Cc: thellstrom@vmware.com, dri-devel@lists.freedesktop.org, Dave Airlie <airlied@redhat.com>
List-Id: dri-devel@lists.freedesktop.org

> +#ifdef CONFIG_SWIOTLB
> +	if (swiotlb_nr_tbl()) {
> +		return ttm_dma_populate(ttm, rdev->dev);
> +	}
> +#endif
..
> +#ifdef CONFIG_SWIOTLB
> +	if (swiotlb_nr_tbl()) {
> +		ttm_dma_unpopulate(ttm, rdev->dev);
> +		return;
> +	}
> +#endif

> +#ifdef CONFIG_SWIOTLB
> +	if (rdev->need_dma32 && swiotlb_nr_tbl()) {
> +		sprintf(radeon_mem_types_names[i], "ttm_dma_page_pool");
> +		radeon_mem_types_list[i].name = radeon_mem_types_names[i];
> +		radeon_mem_types_list[i].show = &ttm_dma_page_alloc_debugfs;
> +		radeon_mem_types_list[i].driver_features = 0;
> +		radeon_mem_types_list[i++].data = NULL;
> +	}
> +#endif

So I think the last one does not need the rdev->need_dma32 as you had
removed it from the other sites.