From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: Dimitris Papastamos <dp@opensource.wolfsonmicro.com>,
Jonathan Cameron <jic23@kernel.org>,
Michael Hennerich <michael.hennerich@analog.com>,
linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
device-drivers-devel@blackfin.uclinux.org, drivers@analog.com
Subject: Re: [PATCH 2/7] regmap: Make reg_config reg_defaults const
Date: Wed, 16 Nov 2011 16:13:17 +0000 [thread overview]
Message-ID: <20111116161316.GI29986@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1321457302-8724-2-git-send-email-lars@metafoo.de>
On Wed, Nov 16, 2011 at 04:28:17PM +0100, Lars-Peter Clausen wrote:
> The reg_defaults field usually points to a static per driver array, which should
> not be modified. Make requirement this explicit by making reg_defaults const.
You should've got reams of sparse warnings from that - the indexed cache
is writing to the defaults table (which is very naughty and i keep
thinking about deleting it as a result).
next prev parent reply other threads:[~2011-11-16 16:13 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-16 15:28 [PATCH 1/7] regmap: Move initialization of regcache related fields to regcache_init Lars-Peter Clausen
2011-11-16 15:28 ` [PATCH 2/7] regmap: Make reg_config reg_defaults const Lars-Peter Clausen
2011-11-16 16:13 ` Mark Brown [this message]
2011-11-16 16:23 ` Lars-Peter Clausen
2011-11-16 16:24 ` Mark Brown
2011-11-16 16:36 ` Lars-Peter Clausen
2011-11-16 16:39 ` Mark Brown
2011-11-16 16:50 ` Lars-Peter Clausen
2011-11-16 16:51 ` Mark Brown
2011-11-16 17:01 ` Lars-Peter Clausen
2011-11-16 17:09 ` Mark Brown
2011-11-16 17:20 ` Lars-Peter Clausen
2011-11-16 17:26 ` Mark Brown
2011-11-16 17:35 ` Mark Brown
2011-11-16 15:28 ` [PATCH 3/7] regmap: Properly round cache_word_size Lars-Peter Clausen
2011-11-16 16:14 ` Mark Brown
2011-11-16 16:25 ` Lars-Peter Clausen
2011-11-16 15:28 ` [PATCH 4/7] regmap: Try cached read before checking if a hardware read is possible Lars-Peter Clausen
2011-11-16 17:35 ` Mark Brown
2011-11-16 15:28 ` [PATCH 5/7] regmap: Check if a register is writable instead of readable in regcache_read Lars-Peter Clausen
2011-11-16 16:16 ` Mark Brown
2011-11-16 16:34 ` Lars-Peter Clausen
2011-11-16 16:38 ` Mark Brown
2011-11-16 16:52 ` Lars-Peter Clausen
2011-11-16 16:56 ` Mark Brown
2011-11-16 17:09 ` Lars-Peter Clausen
2011-11-16 17:12 ` Mark Brown
2011-11-16 17:15 ` Lars-Peter Clausen
2011-11-16 17:22 ` Mark Brown
2011-11-16 15:28 ` [PATCH 6/7] regmap: Add support for 10/14 register formating Lars-Peter Clausen
2011-11-16 17:37 ` Mark Brown
2011-11-16 15:28 ` [PATCH 7/7] staging:iio:dac: Add AD5380 driver Lars-Peter Clausen
2011-11-16 16:56 ` Lars-Peter Clausen
2011-11-17 20:24 ` Jonathan Cameron
2011-11-18 9:08 ` Lars-Peter Clausen
2011-11-18 9:51 ` J.I. Cameron
2011-11-16 17:35 ` [PATCH 1/7] regmap: Move initialization of regcache related fields to regcache_init Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111116161316.GI29986@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=device-drivers-devel@blackfin.uclinux.org \
--cc=dp@opensource.wolfsonmicro.com \
--cc=drivers@analog.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.hennerich@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.