From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from opensource.wolfsonmicro.com ([80.75.67.52]:47966 "EHLO opensource.wolfsonmicro.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752893Ab1KPQOW (ORCPT ); Wed, 16 Nov 2011 11:14:22 -0500 Date: Wed, 16 Nov 2011 16:14:21 +0000 From: Mark Brown To: Lars-Peter Clausen Cc: Dimitris Papastamos , Jonathan Cameron , Michael Hennerich , linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, device-drivers-devel@blackfin.uclinux.org, drivers@analog.com Subject: Re: [PATCH 3/7] regmap: Properly round cache_word_size Message-ID: <20111116161420.GJ29986@opensource.wolfsonmicro.com> References: <1321457302-8724-1-git-send-email-lars@metafoo.de> <1321457302-8724-3-git-send-email-lars@metafoo.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1321457302-8724-3-git-send-email-lars@metafoo.de> Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org On Wed, Nov 16, 2011 at 04:28:18PM +0100, Lars-Peter Clausen wrote: > + if (config->val_bits <= 8) > + map->cache_word_size = 1; > + else if (config->val_bits <= 16) > + map->cache_word_size = 2; > + else > + return -EINVAL; Just do val_bits + 7 if you're going to do this.