From mboxrd@z Thu Jan 1 00:00:00 1970 From: dave.martin@linaro.org (Dave Martin) Date: Wed, 16 Nov 2011 17:39:45 +0000 Subject: [PATCH 3/5] ARM: vexpress: Add DT support in v2m In-Reply-To: <1321463271.3137.380.camel@hornet.cambridge.arm.com> References: <1321036026-23411-1-git-send-email-pawel.moll@arm.com> <1321036026-23411-4-git-send-email-pawel.moll@arm.com> <20111116154402.GE2073@localhost.localdomain> <4EC3E446.4030608@gmail.com> <1321461458.3137.374.camel@hornet.cambridge.arm.com> <4EC3EBEC.3020601@gmail.com> <1321463271.3137.380.camel@hornet.cambridge.arm.com> Message-ID: <20111116173945.GG2073@localhost.localdomain> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Nov 16, 2011 at 05:07:51PM +0000, Pawel Moll wrote: > On Wed, 2011-11-16 at 16:59 +0000, Rob Herring wrote: > > It has nothing to do with taste and obviously documentation changes over > > time. I'm going to start naming everything with legacy because someday > > it all will be... > > > > It's about how you create compatible strings. They should not be > > generic, but specific to particular hardware version. If you happen to > > be compatible with older h/w then you can claim compatibility with that > > older h/w. > > Notice that it's not: > > compatible=legacy > > not even: > > compatible=arm,legacy > > It's: > > compatible=arm,vexpress-legacy > > A specific variant of Versatile Express hardware. It's just that the > "legacy" word carries some meaning. Would it looked better if it was > called: > > compatible=arm,vexpress-nalatenskap > > ? (thanks, google translate ;-) Come to think of it, is the problem here that we're trying to describe the _motherboard_ using the compatible property on the root node. This is why I talked about universal/generic features -- the set of features common to all platforms sharing a single motherboard configuration. Arguably that's wrong, and that compatible property belongs on the motherboard node itself, so: / { compatible = "arm,vexpress-ca9x4" > > > >> If you defined the property when the > > >> original vexpress was designed, it never would have had legacy in the > > >> name. Generally speaking you never change bindings on old platforms. > > >> > > >> So I would have "arm,vexpress" mean legacy and "arm,vexpress-rs1" be the > > >> new memory map. > > > > > > I'd rather second Dave's idea of having > > > > > >>> compatible = "arm,vexpress-", "arm-vexpress-rs1", "arm-vexpress"; > > > > > > and > > > > > >>> + compatible = "arm,vexpress-", "arm,vexpress-legacy", "arm-vexpress"; > > > > If arm,vexpress-ca9 is the only legacy platform, then just drop > > arm,vexpress-legacy altogether. > > It's not. There is additional one, which is not publicly available, but > is using the motherboard in legacy mode. > > Cheers! > > Pawe? > > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Martin Subject: Re: [PATCH 3/5] ARM: vexpress: Add DT support in v2m Date: Wed, 16 Nov 2011 17:39:45 +0000 Message-ID: <20111116173945.GG2073@localhost.localdomain> References: <1321036026-23411-1-git-send-email-pawel.moll@arm.com> <1321036026-23411-4-git-send-email-pawel.moll@arm.com> <20111116154402.GE2073@localhost.localdomain> <4EC3E446.4030608@gmail.com> <1321461458.3137.374.camel@hornet.cambridge.arm.com> <4EC3EBEC.3020601@gmail.com> <1321463271.3137.380.camel@hornet.cambridge.arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <1321463271.3137.380.camel-okZbbLrgpR/YkXV2EHHjLW3o5bpOHsLO@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org To: Pawel Moll Cc: "devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org" , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" List-Id: devicetree@vger.kernel.org T24gV2VkLCBOb3YgMTYsIDIwMTEgYXQgMDU6MDc6NTFQTSArMDAwMCwgUGF3ZWwgTW9sbCB3cm90 ZToKPiBPbiBXZWQsIDIwMTEtMTEtMTYgYXQgMTY6NTkgKzAwMDAsIFJvYiBIZXJyaW5nIHdyb3Rl Ogo+ID4gSXQgaGFzIG5vdGhpbmcgdG8gZG8gd2l0aCB0YXN0ZSBhbmQgb2J2aW91c2x5IGRvY3Vt ZW50YXRpb24gY2hhbmdlcyBvdmVyCj4gPiB0aW1lLiBJJ20gZ29pbmcgdG8gc3RhcnQgbmFtaW5n IGV2ZXJ5dGhpbmcgd2l0aCBsZWdhY3kgYmVjYXVzZSBzb21lZGF5Cj4gPiBpdCBhbGwgd2lsbCBi ZS4uLgo+ID4gCj4gPiBJdCdzIGFib3V0IGhvdyB5b3UgY3JlYXRlIGNvbXBhdGlibGUgc3RyaW5n cy4gVGhleSBzaG91bGQgbm90IGJlCj4gPiBnZW5lcmljLCBidXQgc3BlY2lmaWMgdG8gcGFydGlj dWxhciBoYXJkd2FyZSB2ZXJzaW9uLiBJZiB5b3UgaGFwcGVuIHRvCj4gPiBiZSBjb21wYXRpYmxl IHdpdGggb2xkZXIgaC93IHRoZW4geW91IGNhbiBjbGFpbSBjb21wYXRpYmlsaXR5IHdpdGggdGhh dAo+ID4gb2xkZXIgaC93Lgo+IAo+IE5vdGljZSB0aGF0IGl0J3Mgbm90Ogo+IAo+IAljb21wYXRp YmxlPWxlZ2FjeQo+IAo+IG5vdCBldmVuOgo+IAo+IAljb21wYXRpYmxlPWFybSxsZWdhY3kKPiAK PiBJdCdzOgo+IAkKPiAJY29tcGF0aWJsZT1hcm0sdmV4cHJlc3MtbGVnYWN5Cj4gCj4gQSBzcGVj aWZpYyB2YXJpYW50IG9mIFZlcnNhdGlsZSBFeHByZXNzIGhhcmR3YXJlLiBJdCdzIGp1c3QgdGhh dCB0aGUKPiAibGVnYWN5IiB3b3JkIGNhcnJpZXMgc29tZSBtZWFuaW5nLiBXb3VsZCBpdCBsb29r ZWQgYmV0dGVyIGlmIGl0IHdhcwo+IGNhbGxlZDoKPiAKPiAJY29tcGF0aWJsZT1hcm0sdmV4cHJl c3MtbmFsYXRlbnNrYXAKPiAKPiA/ICh0aGFua3MsIGdvb2dsZSB0cmFuc2xhdGUgOy0pCgpDb21l IHRvIHRoaW5rIG9mIGl0LCBpcyB0aGUgcHJvYmxlbSBoZXJlIHRoYXQgd2UncmUgdHJ5aW5nIHRv IGRlc2NyaWJlCnRoZSBfbW90aGVyYm9hcmRfIHVzaW5nIHRoZSBjb21wYXRpYmxlIHByb3BlcnR5 IG9uIHRoZSByb290IG5vZGUuClRoaXMgaXMgd2h5IEkgdGFsa2VkIGFib3V0IHVuaXZlcnNhbC9n ZW5lcmljIGZlYXR1cmVzIC0tIHRoZSBzZXQgb2YKZmVhdHVyZXMgY29tbW9uIHRvIGFsbCBwbGF0 Zm9ybXMgc2hhcmluZyBhIHNpbmdsZSBtb3RoZXJib2FyZApjb25maWd1cmF0aW9uLgoKQXJndWFi bHkgdGhhdCdzIHdyb25nLCBhbmQgdGhhdCBjb21wYXRpYmxlIHByb3BlcnR5IGJlbG9uZ3Mgb24g dGhlCm1vdGhlcmJvYXJkIG5vZGUgaXRzZWxmLCBzbzoKCi8gewoJY29tcGF0aWJsZSA9ICJhcm0s dmV4cHJlc3MtY2E5eDQiCgoKPiAKPiA+ID4+IElmIHlvdSBkZWZpbmVkIHRoZSBwcm9wZXJ0eSB3 aGVuIHRoZQo+ID4gPj4gb3JpZ2luYWwgdmV4cHJlc3Mgd2FzIGRlc2lnbmVkLCBpdCBuZXZlciB3 b3VsZCBoYXZlIGhhZCBsZWdhY3kgaW4gdGhlCj4gPiA+PiBuYW1lLiBHZW5lcmFsbHkgc3BlYWtp bmcgeW91IG5ldmVyIGNoYW5nZSBiaW5kaW5ncyBvbiBvbGQgcGxhdGZvcm1zLgo+ID4gPj4KPiA+ ID4+IFNvIEkgd291bGQgaGF2ZSAiYXJtLHZleHByZXNzIiBtZWFuIGxlZ2FjeSBhbmQgImFybSx2 ZXhwcmVzcy1yczEiIGJlIHRoZQo+ID4gPj4gbmV3IG1lbW9yeSBtYXAuCj4gPiA+IAo+ID4gPiBJ J2QgcmF0aGVyIHNlY29uZCBEYXZlJ3MgaWRlYSBvZiBoYXZpbmcKPiA+ID4gCj4gPiA+Pj4gCWNv bXBhdGlibGUgPSAiYXJtLHZleHByZXNzLTxtb2RlbD4iLCAiYXJtLXZleHByZXNzLXJzMSIsICJh cm0tdmV4cHJlc3MiOwo+ID4gPiAKPiA+ID4gYW5kCj4gPiA+IAo+ID4gPj4+ICsJY29tcGF0aWJs ZSA9ICJhcm0sdmV4cHJlc3MtPG1vZGVsPiIsICJhcm0sdmV4cHJlc3MtbGVnYWN5IiwgImFybS12 ZXhwcmVzcyI7Cj4gPiAKPiA+IElmIGFybSx2ZXhwcmVzcy1jYTkgaXMgdGhlIG9ubHkgbGVnYWN5 IHBsYXRmb3JtLCB0aGVuIGp1c3QgZHJvcAo+ID4gYXJtLHZleHByZXNzLWxlZ2FjeSBhbHRvZ2V0 aGVyLgo+IAo+IEl0J3Mgbm90LiBUaGVyZSBpcyBhZGRpdGlvbmFsIG9uZSwgd2hpY2ggaXMgbm90 IHB1YmxpY2x5IGF2YWlsYWJsZSwgYnV0Cj4gaXMgdXNpbmcgdGhlIG1vdGhlcmJvYXJkIGluIGxl Z2FjeSBtb2RlLgo+IAo+IENoZWVycyEKPiAKPiBQYXdlxYIKPiAKPiAKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZGV2aWNldHJlZS1kaXNjdXNzIG1haWxp bmcgbGlzdApkZXZpY2V0cmVlLWRpc2N1c3NAbGlzdHMub3psYWJzLm9yZwpodHRwczovL2xpc3Rz Lm96bGFicy5vcmcvbGlzdGluZm8vZGV2aWNldHJlZS1kaXNjdXNzCg==