From: Christian Lamparter <chunkeey@googlemail.com>
To: "Michael Büsch" <m@bues.ch>
Cc: "John W. Linville" <linville@tuxdriver.com>,
"linux-wireless" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] p54spi: Remove FIXME in op_stop
Date: Thu, 17 Nov 2011 00:12:03 +0100 [thread overview]
Message-ID: <201111170012.03948.chunkeey@googlemail.com> (raw)
In-Reply-To: <20111116235120.4c60c066@milhouse>
On Wednesday, November 16, 2011 11:51:20 PM Michael Büsch wrote:
> Don't use the interruptible variant of mutex_lock(). It doesn't really
> need to be interruptible. This avoids nasty error handling.
>
> Signed-off-by: Michael Buesch <m@bues.ch>
Acked-by: Christian Lamparter <chunkeey@googlemail.com>
BTW: I always wondered if it would make sense to have a
cached rx skb ready in p54spi_rx(). This way we don't
have to do DMA onto the stack [which is really ugly and
possibly illegal] and might even get a better rx
performance. I could write the code but as you know I don't
have the hardware to test it.
Regards,
Christian
next parent reply other threads:[~2011-11-16 23:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20111116235120.4c60c066@milhouse>
2011-11-16 23:12 ` Christian Lamparter [this message]
2011-11-16 23:15 ` [PATCH] p54spi: Remove FIXME in op_stop Michael Büsch
2011-11-19 17:59 ` [RFC] p54spi: don't DMA onto the stack Christian Lamparter
2011-11-19 22:15 ` Max Filippov
2011-11-19 22:56 ` Christian Lamparter
2011-11-20 0:48 ` Max Filippov
2011-11-20 13:24 ` Christian Lamparter
2011-11-20 14:36 ` Max Filippov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201111170012.03948.chunkeey@googlemail.com \
--to=chunkeey@googlemail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=m@bues.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.