From: Paul Mundt <lethal@linux-sh.org>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH 1/3] sh: sh7724: use runtime PM implementation, common with arm/mach-shmobile
Date: Thu, 17 Nov 2011 05:39:41 +0000 [thread overview]
Message-ID: <20111117053940.GA30555@linux-sh.org> (raw)
In-Reply-To: <Pine.LNX.4.64.1111161306190.1100@axis700.grange>
On Wed, Nov 16, 2011 at 01:35:42PM +0100, Guennadi Liakhovetski wrote:
> @@ -195,61 +198,64 @@ static struct clk div6_reparent_clks[DIV6_REPARENT_NR] = {
> fclkbcr_parent, ARRAY_SIZE(fclkbcr_parent), 6, 2),
> };
>
> +#define MSTP(_parent, _reg, _bit, _flags) \
> + SH_CLK_MSTP32(_parent, _reg, _bit, _flags)
> +
> static struct clk mstp_clks[HWBLK_NR] = {
> - SH_HWBLK_CLK(HWBLK_TLB, &div4_clks[DIV4_I], CLK_ENABLE_ON_INIT),
..
> + [HWBLK_TLB] = MSTP(&div4_clks[DIV4_I], MSTPCR0, 31, CLK_ENABLE_ON_INIT),
No, I'm not interested in wrappers to wrappers. Just use SH_CLK_MSTP32
directly. If you're adhering to 80 character lines you can just do some
additional formatting where necessary.
Other then that it's a good start. I assume once these are tidied up
you'll be sending patches to strip out the hwblk stuff as well as the
shmobile runtime PM implementation completely?
prev parent reply other threads:[~2011-11-17 5:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-16 12:35 [PATCH 1/3] sh: sh7724: use runtime PM implementation, common with Guennadi Liakhovetski
2011-11-17 5:39 ` Paul Mundt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111117053940.GA30555@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.