Re: HID: Dead ./debug/hid/xxx/events

[Cedric Sodhi <manday@gmx.net>]

On Wed, Nov 16, 2011 at 10:22:58PM +0100, Benjamin Tissoires wrote:
> Hi Chris,
> 
> it looks like the quirks were not taken into account.
> Normally, you don't need to manually add the VID:PID with the sysfs as
> you already registered your device in the list.

Assuming that it was me who you were addressing: I'm aware of that. As
the diff shows, I added the device to the "hardcoded" whitelist as
MULTITOUCH5, using the quirks SLOT_IS_CONTACTID and ALWAYS_VALID.
> 
> 1) What is the value of the quirks sysfs attrib ? (according to your
> logs, it should show 1, instead of 18)

Cat'ing quirks returns 18. Conclusion ahead: I think I must have taken
those logs in the TAR file before I added the device to the whitelist
and then forgot to write out the quirks to sysfs, while manually adding
it.

> 
> 2) did you do depmod and are you sure the hid-multitouch module loaded
> is the one with USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH5?
> to be sure, please provide the outputs of:
> $ modinfo hid-multitouch
> $ modinfo <path to jiri-hid>/drivers/hid/hid-multitouch.ko
> 
> If you added your device through the sysfs because it was not taken by
> hid-multitouch, replace the last parameter by 104:
> $ echo 3 0eef a001 104 > new_id
> But again, this is not the right way as you registered it.
> 

Therefore, no, everything seems to work now. The device is picked up
through the patch and, according to Chris, returns the correct values.

The log which I attached to my last email was the one I took after
making the changes to the code. I forgot to specify that.

Cedric

> Cheers,
> Benjamin
> 
> 
> On Wed, Nov 16, 2011 at 21:48, Cedric Sodhi <manday@gmx.net> wrote:
> > Dear Benjamin,
> >
> > I applied your patch tp 3.2-jikos (uname shows 3.1, though). The
> > diff to jikos' original is now [attached].
> >
> > Chris says the output of evtest still signifies problems with
> > multitouch:
> >
> >> > http://ompldr.org/iYmIzYw
> >>
> >> Cedric, can you send these logs to Benjamin for ideas?  The HID events
> >> look good but the evtest log for 2 fingers is not.  The two touches
> >> are fighting each other.  That "-1" value is interrupted as each
> >> finger is being lifted in between each new X/Y report.
> >>
> >> Also, can you send me and Benjamin the source code diff of what your
> >> testing against kernel tree?
> >>
> >> The behavior in your evtest log looks like what would happen if your
> >> setting the MT_QUIRK_NOT_SEEN_MEANS_UP.  Since your HW only sends 1
> >> fingers worth of data per packet, you do not want that quirk.
> >>
> >> I'll still hold off on xf86-input-wacom issues until the events coming
> >> are sane.  Your current events will cause xf86-input-wacom to do all
> >> kinds of weird stuff thats not worth effort to weed threw.
> >>
> >> Chris
> >
> > These logs in that tarfile were created while still manually adding the
> > ID via your sysfs interface. You find yet another evtest log for
> > two-finger touch attached.
> >
> > Cedric
> >
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html