From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Date: Thu, 17 Nov 2011 08:56:58 +0100 Subject: [U-Boot] [PATCH] disk: part_efi: Fix parameters passed to is_gpt_valid(). In-Reply-To: <1321513477-12877-1-git-send-email-thierry.reding@avionic-design.de> References: <1321513477-12877-1-git-send-email-thierry.reding@avionic-design.de> Message-ID: <20111117075658.GA11853@avionic-0098.mockup.avionic-design.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de * Thierry Reding wrote: > Something apparently went wrong when the patch in commit deb5ca8 was > applied. Commit f75dd58 changed the type of gpt_head to be a pointer and > correctly adjusted the calls to is_gpt_valid(). But when deb5ca8 got > applied, the gpt_head was again reverted to &(gpt_head), which was the > state before deb5ca8. > > This commit fixes the passing of gpt_head into is_gpt_valid(). > > Signed-off-by: Thierry Reding > --- > disk/part_efi.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/disk/part_efi.c b/disk/part_efi.c > index e7f2714..ddf80a7 100644 > --- a/disk/part_efi.c > +++ b/disk/part_efi.c > @@ -130,7 +130,7 @@ void print_part_efi(block_dev_desc_t * dev_desc) > } > /* This function validates AND fills in the GPT header and PTE */ > if (is_gpt_valid(dev_desc, GPT_PRIMARY_PARTITION_TABLE_LBA, > - &(gpt_head), &gpt_pte) != 1) { > + gpt_head, &gpt_pte) != 1) { > printf("%s: *** ERROR: Invalid GPT ***\n", __func__); > return; > } > @@ -169,7 +169,7 @@ int get_partition_info_efi(block_dev_desc_t * dev_desc, int part, > > /* This function validates AND fills in the GPT header and PTE */ > if (is_gpt_valid(dev_desc, GPT_PRIMARY_PARTITION_TABLE_LBA, > - &(gpt_head), &gpt_pte) != 1) { > + gpt_head, &gpt_pte) != 1) { > printf("%s: *** ERROR: Invalid GPT ***\n", __func__); > return -1; > } > -- > 1.7.7.3 I had actually set "Doug Anderson " on Cc because he was involved with the initial patch but for some reason he got stripped from Cc. Does anybody know why this is happening? It seems like the To: header is unmodified so perhaps I should only be adding people with --to when sending out patches with "git send-email". Thierry -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 198 bytes Desc: not available Url : http://lists.denx.de/pipermail/u-boot/attachments/20111117/c608a265/attachment.pgp