From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joel Becker Date: Thu, 17 Nov 2011 01:50:21 -0800 Subject: [Ocfs2-devel] [PATCH] ocfs2: send correct UUID to cleancache initialization In-Reply-To: References: Message-ID: <20111117095019.GE7319@noexit.corp.google.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Magenheimer Cc: ocfs2-devel@oss.oracle.com, linux-kernel@vger.kernel.org, Steven Whitehouse , Sunil Mushran On Mon, Oct 17, 2011 at 04:47:17PM -0700, Dan Magenheimer wrote: > ocfs2: Fix cleancache initialization call to correctly pass uuid > > As reported by Steven Whitehouse in https://lkml.org/lkml/2011/5/27/221 > the ocfs2 volume UUID is incorrectly passed to cleancache. > As a result, shared-ephemeral tmem pools will not actually > be created; instead they will be private (unshared) which > misses out on a major benefit of tmem. > > Reported-by: Steven Whitehouse > Signed-off-by: Dan Magenheimer This patch is now in the 'fixes' branch of ocfs2.git. Joel > > diff --git a/fs/ocfs2/super.c b/fs/ocfs2/super.c > --- a/fs/ocfs2/super.c > +++ b/fs/ocfs2/super.c > @@ -2374,7 +2374,7 @@ static int ocfs2_initialize_super(struct super_block *sb, > mlog_errno(status); > goto bail; > } > - cleancache_init_shared_fs((char *)&uuid_net_key, sb); > + cleancache_init_shared_fs((char *)&di->id2.i_super.s_uuid, sb); > > bail: > return status; -- "Well-timed silence hath more eloquence than speech." - Martin Fraquhar Tupper http://www.jlbec.org/ jlbec at evilplan.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756306Ab1KQJue (ORCPT ); Thu, 17 Nov 2011 04:50:34 -0500 Received: from zeniv.linux.org.uk ([195.92.253.2]:60875 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756057Ab1KQJuc (ORCPT ); Thu, 17 Nov 2011 04:50:32 -0500 Date: Thu, 17 Nov 2011 01:50:21 -0800 From: Joel Becker To: Dan Magenheimer Cc: ocfs2-devel@oss.oracle.com, linux-kernel@vger.kernel.org, Steven Whitehouse , Sunil Mushran Subject: Re: [PATCH] ocfs2: send correct UUID to cleancache initialization Message-ID: <20111117095019.GE7319@noexit.corp.google.com> Mail-Followup-To: Dan Magenheimer , ocfs2-devel@oss.oracle.com, linux-kernel@vger.kernel.org, Steven Whitehouse , Sunil Mushran References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Burt-Line: Trees are cool. X-Red-Smith: Ninety feet between bases is perhaps as close as man has ever come to perfection. User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 17, 2011 at 04:47:17PM -0700, Dan Magenheimer wrote: > ocfs2: Fix cleancache initialization call to correctly pass uuid > > As reported by Steven Whitehouse in https://lkml.org/lkml/2011/5/27/221 > the ocfs2 volume UUID is incorrectly passed to cleancache. > As a result, shared-ephemeral tmem pools will not actually > be created; instead they will be private (unshared) which > misses out on a major benefit of tmem. > > Reported-by: Steven Whitehouse > Signed-off-by: Dan Magenheimer This patch is now in the 'fixes' branch of ocfs2.git. Joel > > diff --git a/fs/ocfs2/super.c b/fs/ocfs2/super.c > --- a/fs/ocfs2/super.c > +++ b/fs/ocfs2/super.c > @@ -2374,7 +2374,7 @@ static int ocfs2_initialize_super(struct super_block *sb, > mlog_errno(status); > goto bail; > } > - cleancache_init_shared_fs((char *)&uuid_net_key, sb); > + cleancache_init_shared_fs((char *)&di->id2.i_super.s_uuid, sb); > > bail: > return status; -- "Well-timed silence hath more eloquence than speech." - Martin Fraquhar Tupper http://www.jlbec.org/ jlbec@evilplan.org