From: Jiri Pirko <jpirko@redhat.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
bhutchings@solarflare.com, shemminger@vyatta.com,
andy@greyhouse.net, fbl@redhat.com, jzupka@redhat.com,
ivecera@redhat.com
Subject: Re: [patch net-next 3/3] team: replicate options on register
Date: Thu, 17 Nov 2011 10:57:30 +0100 [thread overview]
Message-ID: <20111117095729.GA2093@minipsycho> (raw)
In-Reply-To: <1321518736.3274.45.camel@edumazet-laptop>
Thu, Nov 17, 2011 at 09:32:16AM CET, eric.dumazet@gmail.com wrote:
>Le mercredi 16 novembre 2011 à 22:09 +0100, Jiri Pirko a écrit :
>
>> +
>> +int team_options_register(struct team *team,
>> + const struct team_option *option,
>> + size_t option_count)
>> {
>> int i;
>> + struct team_option *dst_opts[option_count];
>> + int err;
>
>This kind of construct will trigger static analyzer alerts...
I thought this is ok to do in kernel. Should I replace that with
kmalloc/kfree?
>
>
>
>
next prev parent reply other threads:[~2011-11-17 9:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-16 21:09 [patch net-next 0/3] team: bug fixes Jiri Pirko
2011-11-16 21:09 ` [patch net-next 1/3] team: Do not hold rcu_read_lock when running netlink cmds Jiri Pirko
2011-11-16 21:17 ` Eric Dumazet
2011-11-16 21:55 ` [patch net-next 1/3 v2] " Jiri Pirko
2011-11-17 1:36 ` David Miller
2011-11-16 21:09 ` [patch net-next 2/3] team: convert overall spinlock to mutex Jiri Pirko
2011-11-17 1:36 ` David Miller
2011-11-16 21:09 ` [patch net-next 3/3] team: replicate options on register Jiri Pirko
2011-11-17 1:36 ` David Miller
2011-11-17 8:32 ` Eric Dumazet
2011-11-17 9:57 ` Jiri Pirko [this message]
2011-11-17 10:00 ` Eric Dumazet
2011-11-17 10:03 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111117095729.GA2093@minipsycho \
--to=jpirko@redhat.com \
--cc=andy@greyhouse.net \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=fbl@redhat.com \
--cc=ivecera@redhat.com \
--cc=jzupka@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.