From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Leon Romanovsky <leon@leon.nu>
Cc: alsa-devel@alsa-project.org, lrg@ti.com
Subject: Re: [PATCH 2/6] ASoC: alc5632: Fix compile without CONFIG_I2C
Date: Thu, 17 Nov 2011 14:20:00 +0000 [thread overview]
Message-ID: <20111117141959.GA19918@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <CALq1K=KG1cycVrftOHeCYzaY9WoEwVpgt-8HYvTRrpQ=v7yEWw@mail.gmail.com>
On Wed, Nov 16, 2011 at 09:11:00PM +0200, Leon Romanovsky wrote:
> On Wed, Nov 16, 2011 at 12:35, Mark Brown
> > This is only needed if the driver supports more than one control
> > interface. If it only supports I2C then this should be sorted out at
> > Kconfig stage.
> It is the same as your WM9081 codec, you have entry in Kconfig and
> CONFIG_I2C in the code.
> Anyway this codec is not usable without I2C, so we can drop this patch.
Some devices do have both I2C and SPI support but didn't get round to
adding one bus or the other.
next prev parent reply other threads:[~2011-11-17 14:20 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-16 10:06 [PATCH 0/6] ASoC: Convert ALC5632 codec to use regmap API Leon Romanovsky
2011-11-16 10:06 ` [PATCH 1/6] " Leon Romanovsky
2011-11-16 10:42 ` Mark Brown
2011-11-16 10:06 ` [PATCH 2/6] ASoC: alc5632: Fix compile without CONFIG_I2C Leon Romanovsky
2011-11-16 10:35 ` Mark Brown
2011-11-16 19:11 ` Leon Romanovsky
2011-11-17 14:20 ` Mark Brown [this message]
2011-11-16 10:07 ` [PATCH 3/6] ASoC: alc5632: Fix compile without CONFIG_PM Leon Romanovsky
2011-11-16 10:42 ` Mark Brown
2011-11-16 10:07 ` [PATCH 4/6] ASoC: alc5632: Remove unrelevant registers and name the relevant Leon Romanovsky
2011-11-16 10:36 ` Mark Brown
2011-11-16 10:07 ` [PATCH 5/6] ASoC: alc5632: Added support of two undocumented registers Leon Romanovsky
2011-11-16 10:37 ` Mark Brown
2011-11-16 19:43 ` Leon Romanovsky
2011-11-17 13:42 ` Mark Brown
2011-11-16 10:07 ` [PATCH 6/6] ASoC: alc5632: Update of i2c_probe function to use regmap API only Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111117141959.GA19918@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=leon@leon.nu \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.