From: Flavio Leitner <fbl@redhat.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: David Miller <davem@davemloft.net>,
Ivan Zahariev <famzah@icdsoft.com>,
netdev@vger.kernel.org, Vasiliy Kulikov <segoon@openwall.com>
Subject: Re: Unable to flush ICMP redirect routes in kernel 3.0+
Date: Thu, 17 Nov 2011 15:33:57 -0200 [thread overview]
Message-ID: <20111117153357.7bc5a4d4@asterix.rh> (raw)
In-Reply-To: <1321550302.2751.81.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC>
On Thu, 17 Nov 2011 18:18:22 +0100
Eric Dumazet <eric.dumazet@gmail.com> wrote:
> Le jeudi 17 novembre 2011 à 15:01 -0200, Flavio Leitner a écrit :
>
> > Right, so the loop trying different oif and saddr isn't working at
> > all because __ip_route_output_key() will create a route in the first
> > attempt. Looks like you're right and we need the 'create' parameter
> > in __ip_route_output_key().
>
> And we have to loop on all possible keys combinations.
>
> (like code before David commit (f39925dbde77 ipv4: Cache learned
> redirect information in inetpeer.) : it had a goto do_next;
That is correct. I realize that now.
> I am preparing a patch.
thank you.
fbl
next prev parent reply other threads:[~2011-11-17 17:34 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-15 20:23 Unable to flush ICMP redirect routes in kernel 3.0+ Ivan Zahariev
2011-11-15 21:09 ` Eric Dumazet
2011-11-16 22:32 ` Ivan Zahariev
2011-11-17 0:33 ` Flavio Leitner
2011-11-17 8:10 ` Ivan Zahariev
2011-11-17 13:11 ` Flavio Leitner
2011-11-17 13:15 ` Eric Dumazet
2011-11-17 14:40 ` Eric Dumazet
2011-11-17 15:37 ` Flavio Leitner
2011-11-17 16:31 ` Eric Dumazet
2011-11-17 16:40 ` Flavio Leitner
2011-11-17 16:45 ` Eric Dumazet
2011-11-17 16:57 ` Eric Dumazet
2011-11-17 17:01 ` Flavio Leitner
2011-11-17 17:18 ` Eric Dumazet
2011-11-17 17:33 ` Flavio Leitner [this message]
2011-11-17 17:38 ` Eric Dumazet
2011-11-18 16:02 ` Eric Dumazet
2011-11-18 16:30 ` Flavio Leitner
2011-11-18 16:34 ` Eric Dumazet
2011-11-18 17:05 ` Flavio Leitner
2011-11-18 17:07 ` Eric Dumazet
2011-11-18 17:21 ` Flavio Leitner
2011-11-18 18:04 ` David Miller
2011-11-18 20:26 ` David Miller
2011-11-17 16:52 ` Vasiliy Kulikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111117153357.7bc5a4d4@asterix.rh \
--to=fbl@redhat.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=famzah@icdsoft.com \
--cc=netdev@vger.kernel.org \
--cc=segoon@openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.